lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu,  9 Nov 2017 06:55:26 -0800
From:   Andi Kleen <>
        Andi Kleen <>
Subject: [PATCH v1 3/5] perf, tools, script: Allow printing period for non freq mode groups

From: Andi Kleen <>

When using leader sampling the values of the not sampled but counted
events are shown by perf script in "period".

Currently printing period is only allowed when the main event
has a period, that is it is in frequency mode.

This implies that we cannot dump the values of counted events
when the leader event is not in frequency mode.

Just remove the check that the period must be set on all
events. It will just be printed as 0 instead if it's not

This fixes the following:

$ perf record -c 100000 -e '{cycles,branches}:S'
$ perf script -F event,period

Signed-off-by: Andi Kleen <>
 tools/perf/builtin-script.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
index 9092de0f7238..34d8b766e518 100644
--- a/tools/perf/builtin-script.c
+++ b/tools/perf/builtin-script.c
@@ -377,11 +377,6 @@ static int perf_evsel__check_attr(struct perf_evsel *evsel,
 					   PERF_OUTPUT_CPU, allow_user_set))
 		return -EINVAL;
-		perf_evsel__check_stype(evsel, PERF_SAMPLE_PERIOD, "PERIOD",
-		return -EINVAL;
 		perf_evsel__check_stype(evsel, PERF_SAMPLE_REGS_INTR, "IREGS",

Powered by blists - more mailing lists