linux-kernel - Re: [PATCH 1/4] arm64: dts: qcom: pm8916: fix wcd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20171109164941.GZ28761@minitux>
Date:   Thu, 9 Nov 2017 08:49:41 -0800
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Damien Riegel <damien.riegel@...oirfairelinux.com>
Cc:     linux-arm-msm@...r.kernel.org, linux-soc@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, Andy Gross <andy.gross@...aro.org>,
        David Brown <david.brown@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>, kernel@...oirfairelinux.com
Subject: Re: [PATCH 1/4] arm64: dts: qcom: pm8916: fix wcd_codec indentation

On Wed 01 Nov 10:53 PDT 2017, Damien Riegel wrote:

> Indentation did not respect kernel standards, so fix that for the usual
> indent with tabs, align with spaces. While at it, remove some empty
> lines before and after the closing parenthesis of this block.
> 
> Signed-off-by: Damien Riegel <damien.riegel@...oirfairelinux.com>

Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>

Regards,
Bjorn

> ---
>  arch/arm64/boot/dts/qcom/pm8916.dtsi | 82 ++++++++++++++++++------------------
>  1 file changed, 40 insertions(+), 42 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/pm8916.dtsi b/arch/arm64/boot/dts/qcom/pm8916.dtsi
> index 53deebf9f515..d19f4cb9a5f3 100644
> --- a/arch/arm64/boot/dts/qcom/pm8916.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm8916.dtsi
> @@ -96,47 +96,45 @@
>  		#address-cells = <1>;
>  		#size-cells = <0>;
>  
> -                wcd_codec: codec@...0 {
> -                       compatible = "qcom,pm8916-wcd-analog-codec";
> -	               reg = <0xf000 0x200>;
> -	               reg-names = "pmic-codec-core";
> -	               clocks = <&gcc GCC_CODEC_DIGCODEC_CLK>;
> -	               clock-names = "mclk";
> -	               interrupt-parent = <&spmi_bus>;
> -	               interrupts = <0x1 0xf0 0x0 IRQ_TYPE_NONE>,
> -	                            <0x1 0xf0 0x1 IRQ_TYPE_NONE>,
> -	                            <0x1 0xf0 0x2 IRQ_TYPE_NONE>,
> -	                            <0x1 0xf0 0x3 IRQ_TYPE_NONE>,
> -	                            <0x1 0xf0 0x4 IRQ_TYPE_NONE>,
> -	                            <0x1 0xf0 0x5 IRQ_TYPE_NONE>,
> -	                            <0x1 0xf0 0x6 IRQ_TYPE_NONE>,
> -	                            <0x1 0xf0 0x7 IRQ_TYPE_NONE>,
> -	                            <0x1 0xf1 0x0 IRQ_TYPE_NONE>,
> -	                            <0x1 0xf1 0x1 IRQ_TYPE_NONE>,
> -	                            <0x1 0xf1 0x2 IRQ_TYPE_NONE>,
> -	                            <0x1 0xf1 0x3 IRQ_TYPE_NONE>,
> -	                            <0x1 0xf1 0x4 IRQ_TYPE_NONE>,
> -	                            <0x1 0xf1 0x5 IRQ_TYPE_NONE>;
> -	               interrupt-names = "cdc_spk_cnp_int",
> -	                                 "cdc_spk_clip_int",
> -	                                 "cdc_spk_ocp_int",
> -	                                 "mbhc_ins_rem_det1",
> -	                                 "mbhc_but_rel_det",
> -	                                 "mbhc_but_press_det",
> -	                                 "mbhc_ins_rem_det",
> -	                                 "mbhc_switch_int",
> -	                                 "cdc_ear_ocp_int",
> -	                                 "cdc_hphr_ocp_int",
> -	                                 "cdc_hphl_ocp_det",
> -	                                 "cdc_ear_cnp_int",
> -	                                 "cdc_hphr_cnp_int",
> -	                                 "cdc_hphl_cnp_int";
> -	               vdd-cdc-io-supply = <&pm8916_l5>;
> -	               vdd-cdc-tx-rx-cx-supply = <&pm8916_l5>;
> -	               vdd-micbias-supply = <&pm8916_l13>;
> -	               #sound-dai-cells = <1>;
> -
> -                };
> -
> +		wcd_codec: codec@...0 {
> +			compatible = "qcom,pm8916-wcd-analog-codec";
> +			reg = <0xf000 0x200>;
> +			reg-names = "pmic-codec-core";
> +			clocks = <&gcc GCC_CODEC_DIGCODEC_CLK>;
> +			clock-names = "mclk";
> +			interrupt-parent = <&spmi_bus>;
> +			interrupts = <0x1 0xf0 0x0 IRQ_TYPE_NONE>,
> +				     <0x1 0xf0 0x1 IRQ_TYPE_NONE>,
> +				     <0x1 0xf0 0x2 IRQ_TYPE_NONE>,
> +				     <0x1 0xf0 0x3 IRQ_TYPE_NONE>,
> +				     <0x1 0xf0 0x4 IRQ_TYPE_NONE>,
> +				     <0x1 0xf0 0x5 IRQ_TYPE_NONE>,
> +				     <0x1 0xf0 0x6 IRQ_TYPE_NONE>,
> +				     <0x1 0xf0 0x7 IRQ_TYPE_NONE>,
> +				     <0x1 0xf1 0x0 IRQ_TYPE_NONE>,
> +				     <0x1 0xf1 0x1 IRQ_TYPE_NONE>,
> +				     <0x1 0xf1 0x2 IRQ_TYPE_NONE>,
> +				     <0x1 0xf1 0x3 IRQ_TYPE_NONE>,
> +				     <0x1 0xf1 0x4 IRQ_TYPE_NONE>,
> +				     <0x1 0xf1 0x5 IRQ_TYPE_NONE>;
> +			interrupt-names = "cdc_spk_cnp_int",
> +					  "cdc_spk_clip_int",
> +					  "cdc_spk_ocp_int",
> +					  "mbhc_ins_rem_det1",
> +					  "mbhc_but_rel_det",
> +					  "mbhc_but_press_det",
> +					  "mbhc_ins_rem_det",
> +					  "mbhc_switch_int",
> +					  "cdc_ear_ocp_int",
> +					  "cdc_hphr_ocp_int",
> +					  "cdc_hphl_ocp_det",
> +					  "cdc_ear_cnp_int",
> +					  "cdc_hphr_cnp_int",
> +					  "cdc_hphl_cnp_int";
> +			vdd-cdc-io-supply = <&pm8916_l5>;
> +			vdd-cdc-tx-rx-cx-supply = <&pm8916_l5>;
> +			vdd-micbias-supply = <&pm8916_l13>;
> +			#sound-dai-cells = <1>;
> +		};
>  	};
>  };
> -- 
> 2.15.0
>