linux-kernel - RE: [PATCH] IB/qib: remove redundant setting of any in for-loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 10 Nov 2017 19:07:15 +0000
From:   "Marciniszyn, Mike" <mike.marciniszyn@...el.com>
To:     Doug Ledford <dledford@...hat.com>, Joe Perches <joe@...ches.com>,
        "Colin King" <colin.king@...onical.com>,
        "Hefty, Sean" <sean.hefty@...el.com>,
        "Hal Rosenstock" <hal.rosenstock@...il.com>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>
CC:     "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Dalessandro, Dennis" <dennis.dalessandro@...el.com>
Subject: RE: [PATCH] IB/qib: remove redundant setting of any in for-loop

> > On Fri, 2017-10-20 at 09:21 +0200, Colin King wrote:
> > > From: Colin Ian King <colin.king@...onical.com>
> > >
> > > The variable all is being set but is never read after this
> > > hence it can be removed from the for loop initialization.
> > > Cleans up clang warning:
> >
> > any is really used as bool and is initialized at function
> > entry.  The earlier loop also reinitializes any unnecessarily.
> 
> Denny, can you weigh in on what you want in this thread?  Thanks.
> 

I am ok with both Colin's and Joe's patch.

Joe's patch would require additional testing vs. the trivial warning fix.

Then there is a "guideline"  to keep fixes separate from clean up...

Doug,  do you want a tested patch from me?

Mike