linux-kernel - Re: [PATCH] IB/qib: remove redundant setting of any in for-loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1510609978.3735.43.camel@redhat.com>
Date:   Mon, 13 Nov 2017 16:52:58 -0500
From:   Doug Ledford <dledford@...hat.com>
To:     "Marciniszyn, Mike" <mike.marciniszyn@...el.com>,
        Joe Perches <joe@...ches.com>,
        Colin King <colin.king@...onical.com>,
        "Hefty, Sean" <sean.hefty@...el.com>,
        Hal Rosenstock <hal.rosenstock@...il.com>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>
Cc:     "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Dalessandro, Dennis" <dennis.dalessandro@...el.com>
Subject: Re: [PATCH] IB/qib: remove redundant setting of any in for-loop

On Fri, 2017-11-10 at 19:07 +0000, Marciniszyn, Mike wrote:
> > > On Fri, 2017-10-20 at 09:21 +0200, Colin King wrote:
> > > > From: Colin Ian King <colin.king@...onical.com>
> > > > 
> > > > The variable all is being set but is never read after this
> > > > hence it can be removed from the for loop initialization.
> > > > Cleans up clang warning:
> > > 
> > > any is really used as bool and is initialized at function
> > > entry.  The earlier loop also reinitializes any unnecessarily.
> > 
> > Denny, can you weigh in on what you want in this thread?  Thanks.
> > 
> 
> I am ok with both Colin's and Joe's patch.
> 
> Joe's patch would require additional testing vs. the trivial warning fix.
> 
> Then there is a "guideline"  to keep fixes separate from clean up...
> 
> Doug,  do you want a tested patch from me?

Preferably, yes :-)

-- 
Doug Ledford <dledford@...hat.com>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)