linux-kernel - Re: [PATCH v12 3/5] mfd: Add driver for RAVE Supervisory Processor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201711130358.AB1vHR42%fengguang.wu@intel.com>
Date:   Mon, 13 Nov 2017 03:18:52 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Andrey Smirnov <andrew.smirnov@...il.com>
Cc:     kbuild-all@...org, linux-kernel@...r.kernel.org,
        Andrey Smirnov <andrew.smirnov@...il.com>, cphealy@...il.com,
        Lucas Stach <l.stach@...gutronix.de>,
        Nikita Yushchenko <nikita.yoush@...entembedded.com>,
        Lee Jones <lee.jones@...aro.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Pavel Machek <pavel@....cz>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Guenter Roeck <linux@...ck-us.net>,
        Rob Herring <robh@...nel.org>, Johan Hovold <johan@...nel.org>,
        Sebastian Reichel <sebastian.reichel@...labora.co.uk>
Subject: Re: [PATCH v12 3/5] mfd: Add driver for RAVE Supervisory Processor

Hi Andrey,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v4.14-rc8]
[cannot apply to next-20171110]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Andrey-Smirnov/ZII-RAVE-platform-driver/20171112-215306
config: arm-allyesconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=arm 

All errors (new ones prefixed by >>):

   drivers/mfd/rave-sp.c: In function 'csum_ccitt':
>> drivers/mfd/rave-sp.c:237:25: error: implicit declaration of function 'crc_ccitt_false'; did you mean 'crc_ccitt_byte'? [-Werror=implicit-function-declaration]
     const u16 calculated = crc_ccitt_false(0xffff, buf, size);
                            ^~~~~~~~~~~~~~~
                            crc_ccitt_byte
   cc1: some warnings being treated as errors

vim +237 drivers/mfd/rave-sp.c

   234	
   235	static void csum_ccitt(const u8 *buf, size_t size, u8 *crc)
   236	{
 > 237		const u16 calculated = crc_ccitt_false(0xffff, buf, size);
   238	
   239		/*
   240		 * While the rest of the wire protocol is little-endian,
   241		 * CCITT-16 CRC in RDU2 device is sent out in big-endian order.
   242		 */
   243		put_unaligned_be16(calculated, crc);
   244	}
   245	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (63324 bytes)