linux-kernel - Re: [PATCH 5/5] USB: Add format_template attribute to struct usb_class

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171113140038.GA3436@kroah.com>
Date:   Mon, 13 Nov 2017 15:00:38 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Rasmus Villemoes <linux@...musvillemoes.dk>
Cc:     Kees Cook <keescook@...omium.org>, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/5] USB: Add format_template attribute to struct
 usb_class_driver

On Sun, Nov 12, 2017 at 10:19:11PM +0100, Rasmus Villemoes wrote:
> This serves as human-readable documentation as well as allowing the
> format_template plugin to complain about any static initializers of this
> struct member that do not have the same set of printf specifiers.
> 
> Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk>
> ---
>  include/linux/usb.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/usb.h b/include/linux/usb.h
> index 9c63792a8134..8d48c0cd1c01 100644
> --- a/include/linux/usb.h
> +++ b/include/linux/usb.h
> @@ -1236,7 +1236,7 @@ extern struct bus_type usb_bus_type;
>   * parameters used for them.
>   */
>  struct usb_class_driver {
> -	char *name;
> +	char *name __format_template("foobar_%d");
>  	char *(*devnode)(struct device *dev, umode_t *mode);
>  	const struct file_operations *fops;
>  	int minor_base;


Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>