linux-kernel - Re: [PATCH 3/5] staging: speakup: Apply format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171113140050.GB3436@kroah.com>
Date:   Mon, 13 Nov 2017 15:00:50 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Rasmus Villemoes <linux@...musvillemoes.dk>
Cc:     Kees Cook <keescook@...omium.org>, speakup@...ux-speakup.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/5] staging: speakup: Apply format_template attribute

On Sun, Nov 12, 2017 at 10:19:09PM +0100, Rasmus Villemoes wrote:
> This serves as human-readable documentation as well as allowing the
> format_template plugin to complain about any static initializers of this
> struct member that do not have the same set of printf specifiers.
> 
> Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk>
> ---
>  drivers/staging/speakup/spk_types.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/speakup/spk_types.h b/drivers/staging/speakup/spk_types.h
> index c50de6035a9a..156000c0c4d3 100644
> --- a/drivers/staging/speakup/spk_types.h
> +++ b/drivers/staging/speakup/spk_types.h
> @@ -108,7 +108,7 @@ struct st_var_header {
>  };
>  
>  struct num_var_t {
> -	char *synth_fmt;
> +	char *synth_fmt __format_template("%d");
>  	int default_val;
>  	int low;
>  	int high;
> -- 
> 2.11.0

Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>