linux-kernel - Re: [PATCH] lockdep: Add missing declaration of 'pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171113150914.kpgtalzgssx44do3@sasha-lappy>
Date:   Mon, 13 Nov 2017 15:09:17 +0000
From:   alexander.levin@...izon.com
To:     Alexander Sverdlin <alexander.sverdlin@...il.com>
CC:     Mengting Zhang <zhangmengting@...wei.com>,
        "ben@...adent.org.uk" <ben@...adent.org.uk>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "huawei.libin@...wei.com" <huawei.libin@...wei.com>
Subject: Re: [PATCH] lockdep: Add missing declaration of 'pr_cont()'

On Tue, Nov 07, 2017 at 05:10:07PM +0100, Alexander Sverdlin wrote:
>Hello!
>
>On Tue Nov   7 03:24:20 2017 Mengting Zhang <zhangmengting@...wei.com> wrote:
>> An annoying compile warning due to missing declaration is shown below:
>> In file included from lockdep.c:27:0:
>> ../../../kernel/locking/lockdep.c: In function
>> 'print_unlock_imbalance_bug' : ../../../kernel/locking/lockdep.c:3544:2:
>> warning: implicit declaration of function 'pr_cont'
>> [-Wimplicit-function-declaration]   pr_cont(") at:\n");   ^
>> Adding the declaration of 'pr_cont' fixes the problem.
>>
>> Signed-off-by: Mengting Zhang <zhangmengting@...wei.com>
>
>Your commit brought my attention to the fact that commit 681fbec881 brought a regression, rendering 20fb654ae fix ineffective.
>
>But this is not related to your change, which I believe is correct:
>Reviewed-by: Alexander Sverdlin <alexander.sverdlin@...il.com>

Thanks! Queued up.

-- 

Thanks,
Sasha