lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 13 Nov 2017 15:10:49 +0000 From: Sudeep Holla <sudeep.holla@....com> To: Daniel Lezcano <daniel.lezcano@...aro.org> Cc: Arnd Bergmann <arnd@...db.de>, Sudeep Holla <sudeep.holla@....com>, Thomas Gleixner <tglx@...utronix.de>, Benjamin Gaignard <benjamin.gaignard@...aro.org>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] clocksource/drivers/timer-of: mark timer_of_exit as __init On 13/11/17 14:58, Daniel Lezcano wrote: > On 13/11/2017 11:11, Sudeep Holla wrote: [..] >> >> Agreed, may be if we add users which is called from init functions, the >> warning should disappear. Also as tglx suggested, we could rename if it's >> just used from init function error/exit paths. > > The drivers are not compiled as module AFAICT, the function will be > called in the init error path. > Understood, IMO better to rename the functions as cleanup or something similar. exit made it sound differently and since there were no users, I assumed it to be used in remove/exit functions. Sorry for the noise. -- Regards, Sudeep
Powered by blists - more mailing lists