linux-kernel - Re: [PATCH V2 2/2] mfd: cros ec: spi: Simplify delay handling between SPI messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=XS3kuVx7hcGTNYVwxjUj83e7Jo9azEw00PbOQRO8wJ1w@mail.gmail.com>
Date:   Tue, 14 Nov 2017 10:47:30 -0800
From:   Doug Anderson <dianders@...omium.org>
To:     Jon Hunter <jonathanh@...dia.com>
Cc:     Lee Jones <lee.jones@...aro.org>,
        LKML <linux-kernel@...r.kernel.org>, linux-tegra@...r.kernel.org,
        Brian Norris <briannorris@...omium.org>,
        Shawn Nematbakhsh <shawnn@...omium.org>,
        Benson Leung <bleung@...omium.org>
Subject: Re: [PATCH V2 2/2] mfd: cros ec: spi: Simplify delay handling between
 SPI messages

Hi,

On Tue, Nov 14, 2017 at 6:43 AM, Jon Hunter <jonathanh@...dia.com> wrote:
> The EC SPI driver prevents SPI transfers being to rapidly by keeping
> track of the time the last transfer was issued via the
> 'last_transfer_ns' variable. Previously, if the 'last_transfer_ns'
> variable was zero, this indicated that no previous transfer had been
> sent and that no delay was needed. However, the EC SPI driver has
> been updated to always initialise the 'last_transfer_ns' variable
> during probe and therefore, it is no longer necessary to test if it
> is zero. Remove the code that checks if this variable is zero.
>
> Signed-off-by: Jon Hunter <jonathanh@...dia.com>
> Reviewed-by: Brian Norris <briannorris@...omium.org>
> ---
> Changes since V1:
> - Added Brian's reviewed-by.
>
>  drivers/mfd/cros_ec_spi.c | 25 +++++++++----------------
>  1 file changed, 9 insertions(+), 16 deletions(-)

Reviewed-by: Douglas Anderson <dianders@...omium.org>