linux-kernel - Re: [PATCH] x86/mce: add support SRAO reported via CMC check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171114185139.oo6dr6opk7nup3or@agluck-desk>
Date:   Tue, 14 Nov 2017 10:51:39 -0800
From:   "Luck, Tony" <tony.luck@...el.com>
To:     Xie XiuQi <xiexiuqi@...wei.com>
Cc:     bp@...en8.de, tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
        x86@...nel.org, linux-edac@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/mce: add support SRAO reported via CMC check

On Tue, Nov 14, 2017 at 01:55:11PM +0800, Xie XiuQi wrote:
> +	/* known AO MCACODs reported via CMC: */
> +	MCESEV(
> +		AO, "Action optional: memory scrubbing error",
> +		SER, MASK(MCI_UC_SAR|MCACOD_SCRUBMSK, MCI_STATUS_UC|MCACOD_SCRUB)

I think you should check for OVER=0 (as the existing AO cases do).
If there was a patrol scrub reported by CMCI, and then another UC
error, we can't safely treat this as an AO ... because we have no
idea what the second UC error was.

-Tony