linux-kernel - Re: [PATCH v5 1/2] x86/mm: add a function to check if a pfn is UC/UC-

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <df0141a3-423a-4845-1636-dc3507e70f94@redhat.com>
Date:   Wed, 15 Nov 2017 11:44:24 +0100
From:   David Hildenbrand <david@...hat.com>
To:     Haozhong Zhang <haozhong.zhang@...el.com>, kvm@...r.kernel.org,
        x86@...nel.org
Cc:     linux-kernel@...r.kernel.org, Paolo Bonzini <pbonzini@...hat.com>,
        rkrcmar@...hat.com, Xiao Guangrong <xiaoguangrong.eric@...il.com>,
        Dan Williams <dan.j.williams@...el.com>,
        ivan.d.cuevas.escareno@...el.com, karthik.kumar@...el.com,
        Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
        Olif Chapman <olif.chapman@...cle.com>,
        Mikulas Patocka <mpatocka@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>, Borislav Petkov <bp@...e.de>,
        Tom Lendacky <thomas.lendacky@....com>
Subject: Re: [PATCH v5 1/2] x86/mm: add a function to check if a pfn is UC/UC-

On 08.11.2017 08:56, Haozhong Zhang wrote:
> It will be used by KVM to check whether a pfn should be
> mapped to guest as UC.
> 
> Signed-off-by: Haozhong Zhang <haozhong.zhang@...el.com>
> ---
>  arch/x86/include/asm/pat.h |  2 ++
>  arch/x86/mm/pat.c          | 16 ++++++++++++++++
>  2 files changed, 18 insertions(+)
> 
> diff --git a/arch/x86/include/asm/pat.h b/arch/x86/include/asm/pat.h
> index fffb2794dd89..fabb0cf00e77 100644
> --- a/arch/x86/include/asm/pat.h
> +++ b/arch/x86/include/asm/pat.h
> @@ -21,4 +21,6 @@ int io_reserve_memtype(resource_size_t start, resource_size_t end,
>  
>  void io_free_memtype(resource_size_t start, resource_size_t end);
>  
> +bool pat_pfn_is_uc_or_uc_minus(unsigned long pfn);
> +
>  #endif /* _ASM_X86_PAT_H */
> diff --git a/arch/x86/mm/pat.c b/arch/x86/mm/pat.c
> index fe7d57a8fb60..e1282dd4eeb8 100644
> --- a/arch/x86/mm/pat.c
> +++ b/arch/x86/mm/pat.c
> @@ -677,6 +677,22 @@ static enum page_cache_mode lookup_memtype(u64 paddr)
>  	return rettype;
>  }
>  
> +/**
> + * Check with PAT whether the memory type of a pfn is UC or UC-.
> + *
> + * Only to be called when PAT is enabled.
> + *
> + * Returns true, if the memory type of @pfn is UC or UC-.
> + * Otherwise, returns false.
> + */
> +bool pat_pfn_is_uc_or_uc_minus(unsigned long pfn)
> +{
> +	enum page_cache_mode cm = lookup_memtype(PFN_PHYS(pfn));
> +
> +	return cm == _PAGE_CACHE_MODE_UC || cm == _PAGE_CACHE_MODE_UC_MINUS;
> +}
> +EXPORT_SYMBOL_GPL(pat_pfn_is_uc_or_uc_minus);
> +
>  /**
>   * io_reserve_memtype - Request a memory type mapping for a region of memory
>   * @start: start (physical address) of the region
> 

Wonder if we should check for pat internally. And if we should simply
return the memtype via lookup_memtype() instead of creating such a
strange named function (by providing e.g. a lookup_memtype() variant
that can be called with !pat_enabled()).

The caller can easily check against _PAGE_CACHE_MODE_UC ...


-- 

Thanks,

David / dhildenb