linux-kernel - Re: [PATCH AUTOSEL for 4.9 44/56] ASoC: dwc: Fix PIO mode initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171115105451.5alkuvqesolujgz7@sirena.org.uk>
Date:   Wed, 15 Nov 2017 10:54:51 +0000
From:   Mark Brown <broonie@...nel.org>
To:     alexander.levin@...izon.com
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        Jose Abreu <Jose.Abreu@...opsys.com>,
        Jose Abreu <joabreu@...opsys.com>
Subject: Re: [PATCH AUTOSEL for 4.9 44/56] ASoC: dwc: Fix PIO mode
 initialization

On Wed, Nov 15, 2017 at 02:45:45AM +0000, alexander.levin@...izon.com wrote:

> We can no longer rely on the return value of
> devm_snd_dmaengine_pcm_register(...) to check if the DMA
> handle is declared in the DT.

> Previously this check activated PIO mode but currently
> dma_request_chan returns either a valid channel or -EPROBE_DEFER.

So when did the corresponding change to the dmaengine API go in?

> In order to activate PIO mode check instead if the interrupt
> line is declared. This reflects better what is documented in
> the DT bindings (see Documentation/devicetree/bindings/sound/
> designware-i2s.txt).

> Also, initialize use_pio variable which was never being set
> causing PIO mode to never work.

Though if PIO mode never worked presumably this isn't that urgent...

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)