linux-kernel - Re: [PATCH] drm: mali-dp: Separate static internal data into a read-only structure.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171115192359.GA5486@jade>
Date:   Wed, 15 Nov 2017 17:23:59 -0200
From:   Gustavo Padovan <gustavo@...ovan.org>
To:     Liviu Dudau <Liviu.Dudau@....com>
Cc:     Brian Starkey <brian.starkey@....com>,
        David Airlie <airlied@...ux.ie>,
        LKML <linux-kernel@...r.kernel.org>,
        DRI-devel <dri-devel@...ts.freedesktop.org>,
        Mali DP Maintainers <malidp@...s.arm.com>,
        Daniel Vetter <daniel.vetter@...el.com>
Subject: Re: [PATCH] drm: mali-dp: Separate static internal data into a
 read-only structure.

Hi Liviu,

2017-11-01 Liviu Dudau <Liviu.Dudau@....com>:

> The malidp_hw_device structure that the driver uses to handle the
> differences between versions of the IP contains both non-changeable
> data and fields that get updated at probe time. Previously we were
> copying the read-only part into allocated memory, but that can be
> completely avoided by splitting the structure into a read-only part
> and keeping the runtime modifiable fields into the old structure.
> 
> Reviewed-by: Brian Starkey <brian.starkey@....com>
> Signed-off-by: Liviu Dudau <liviu.dudau@....com>
> ---
>  drivers/gpu/drm/arm/malidp_crtc.c   | 13 ++++----
>  drivers/gpu/drm/arm/malidp_drv.c    | 30 ++++++++---------
>  drivers/gpu/drm/arm/malidp_hw.c     | 46 ++++++++++++++------------
>  drivers/gpu/drm/arm/malidp_hw.h     | 65 ++++++++++++++++++++++---------------
>  drivers/gpu/drm/arm/malidp_planes.c | 19 +++++------
>  5 files changed, 93 insertions(+), 80 deletions(-)

Reviewed-by: Gustavo Padovan <gustavo.padovan@...labora.com>

Gustavo