linux-kernel - RE: [PATCH RFC] lib: simplify bitmap_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MWHPR21MB084523580162E4BFCB56CDD3CB290@MWHPR21MB0845.namprd21.prod.outlook.com>
Date:   Wed, 15 Nov 2017 19:24:15 +0000
From:   Matthew Wilcox <mawilcox@...rosoft.com>
To:     Yury Norov <ynorov@...iumnetworks.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     Andrew Morton <akpm@...ux-foundation.org>,
        Ben Hutchings <ben@...adent.org.uk>,
        David Decotigny <decot@...glers.com>,
        "David S . Miller" <davem@...emloft.net>,
        Rasmus Villemoes <linux@...musvillemoes.dk>
Subject: RE: [PATCH RFC] lib: simplify bitmap_from_u32array API

I certainly approve.  The name sucks too 😉

> @@ -60,7 +60,7 @@
>   * bitmap_find_free_region(bitmap, bits, order)	Find and allocate bit region
>   * bitmap_release_region(bitmap, pos, order)	Free specified bit region
>   * bitmap_allocate_region(bitmap, pos, order)	Allocate specified bit region
> - * bitmap_from_u32array(dst, nbits, buf, nwords) *dst = *buf (nwords 32b
> words)
> + * bitmap_from_u32array(dst, buf, nbits)	*dst = *buf (nwords 32b
> words)

I think this should read:
+ * bitmap_from_u32array(dst, buf, bits)	Copy 'bits' from buf to dst

Also, on LE systems, shouldn't we just use memcpy() for the first bits/8 bytes?