linux-kernel - Re: [PATCH v2 3/4] Add support for AMD Core Perf Extension in guest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2c785f9f-faac-58d5-2efd-3fce80d24c18@amd.com>
Date:   Thu, 16 Nov 2017 12:00:11 -0600
From:   "Natarajan, Janakarajan" <Janakarajan.Natarajan@....com>
To:     Borislav Petkov <bp@...e.de>
Cc:     kvm@...r.kernel.org, x86@...nel.org, linux-kernel@...r.kernel.org,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H . Peter Anvin" <hpa@...or.com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Radim Krcmar <rkrcmar@...hat.com>,
        Len Brown <len.brown@...el.com>, Kyle Huey <me@...ehuey.com>,
        Kan Liang <Kan.liang@...el.com>,
        Grzegorz Andrejczuk <grzegorz.andrejczuk@...el.com>,
        Tom Lendacky <thomas.lendacky@....com>,
        Tony Luck <tony.luck@...el.com>
Subject: Re: [PATCH v2 3/4] Add support for AMD Core Perf Extension in guest

On 11/16/2017 11:25 AM, Borislav Petkov wrote:
> On Thu, Nov 16, 2017 at 11:13:47AM -0600, Natarajan, Janakarajan wrote:
>> On 11/15/2017 1:07 PM, Borislav Petkov wrote:
>>> On Wed, Nov 15, 2017 at 01:04:03PM -0600, Natarajan, Janakarajan wrote:
>>>> So, when the amd_pmu_init is called, a query to guest_cpuid_family() gives a
>>>> value of -1.
>>> And that is because...? And it can be fixed to give the proper guest family I
>>> presume ...?
>> Qemu initially creates a vcpu with KVM_CREATE_VCPU which in kvm initializes
>> the pmu. Later on
>> the cpuid is set using KVM_SET_CPUID2 which sets all the cpuid entries in
>> kvm and the pmu refresh is called.
> That doesn't answer my questions above.

Ah my apologies. So when the pmu is initialized the cpuid entries aren't 
available then. We'll have to wait until the pmu
refresh is called to get the family value. So there is no place to fix 
it. The setting of the nr_counters based
on the family will have to be done in the amd_pmu_refresh() and not in 
the amd_pmu_init().

>