linux-kernel - Re: [GIT PULL 2/3] ARM: SoC driver updates for 4.15

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171116235007.6caupnnbddaguwqr@wfg-t540p.sh.intel.com>
Date:   Fri, 17 Nov 2017 07:50:07 +0800
From:   Fengguang Wu <fengguang.wu@...el.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        arm-soc <arm@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
        Vladimir Barinov <vladimir.barinov@...entembedded.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Simon Horman <horms+renesas@...ge.net.au>,
        Philip Li <philip.li@...el.com>
Subject: Re: [GIT PULL 2/3] ARM: SoC driver updates for 4.15

On Fri, Nov 17, 2017 at 12:25:12AM +0100, Arnd Bergmann wrote:
>On Thu, Nov 16, 2017 at 11:29 PM, Linus Torvalds
><torvalds@...ux-foundation.org> wrote:
>> On Thu, Nov 16, 2017 at 2:02 PM, Arnd Bergmann <arnd@...db.de> wrote:
>>>
>>> ARM: SoC driver updates for v4.15
>>
>> No. This is completely broken, and I can't imagine that it has ever
>> compiled for *anybody*.
>>
>>   drivers/soc/renesas/r8a77970-sysc.c:14:10: fatal error:
>> dt-bindings/power/r8a77970-sysc.h: No such file or directory
>>    #include <dt-bindings/power/r8a77970-sysc.h>
>>
>> and the compiler is completely right. This branch added that
>> r8a77970-sysc.c file, but never added the header file.
>>
>> And it's not some odd merge mistake of mine: I checked. That error is
>> there in the original branch too.
>>
>> Tssk.
>
>Right, I need to figure out how this could have slipped through. I did
>get several "BUILD SUCCESS" mails from the kbuild bot (see
>https://pastebin.com/JDw3EKDZ), which claims to have built it
>successfully in all configurations, including allmodconfig builds on
>arm/arm64 and x86-64. Fengguang, do you remember problems
>with false-negatives recently?

Sorry I checked log and didn't find any 0day reports for that error.

It actually hit the errors several times:

drivers/soc/renesas/r8a77970-sysc.c:14:11: sparse: unable to open 'dt-bindings/power/r8a77970-sysc.h'

2017-10-21 07:23:12 on arm-soc/next/drivers 1c6788e8746d5250ad9bd16e1e48140a396f4733 x86_64-allmodconfig


drivers/soc/renesas/r8a77970-sysc.c:14:45: fatal error: dt-bindings/power/r8a77970-sysc.h: No such file or directory

2017-11-03 07:45:22 on arm-soc/next/drivers 30f3b0678ce6fc46bcdde61ca35821032d0f25b5 i386-allmodconfig
2017-11-03 08:42:45 on arm-soc/next/drivers 30f3b0678ce6fc46bcdde61ca35821032d0f25b5 arm-allmodconfig
2017-11-03 08:43:06 on arm-soc/next/drivers 30f3b0678ce6fc46bcdde61ca35821032d0f25b5 arm64-allmodconfig

So the robot is not working well in that case, I'll work with Philip
to get that fixed.

Regards,
Fengguang