linux-kernel - Re: [RFC v5 09/11] [media] vb2: add infrastructure to support out-fences

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c452dc82-d7a6-4f8a-b4fe-2c98bf41106f@chromium.org>
Date:   Fri, 17 Nov 2017 16:29:04 +0900
From:   Alexandre Courbot <acourbot@...omium.org>
To:     Gustavo Padovan <gustavo@...ovan.org>
Cc:     <linux-media@...r.kernel.org>, Hans Verkuil <hverkuil@...all.nl>,
        Mauro Carvalho Chehab <mchehab@....samsung.com>,
        Shuah Khan <shuahkh@....samsung.com>,
        Pawel Osciak <pawel@...iak.com>,
        Sakari Ailus <sakari.ailus@....fi>,
        Brian Starkey <brian.starkey@....com>,
        Thierry Escande <thierry.escande@...labora.com>,
        <linux-kernel@...r.kernel.org>,
        Gustavo Padovan <gustavo.padovan@...labora.com>
Subject: Re: [RFC v5 09/11] [media] vb2: add infrastructure to support out-fences

On Friday, November 17, 2017 4:19:00 PM JST, Alexandre Courbot wrote:
> On Thursday, November 16, 2017 2:10:55 AM JST, Gustavo Padovan wrote:
>> From: Gustavo Padovan <gustavo.padovan@...labora.com>
>> 
>> Add vb2_setup_out_fence() and the needed members to struct vb2_buffer.
>> 
>> v3:
>> 	- Do not hold yet another ref to the out_fence (Brian Starkey)
>> 
>> v2:	- change it to reflect fd_install at DQEVENT ...
>
> out_fence_fd is allocated in this patch but not used anywhere 
> for the moment.
> For consistency, maybe move its allocation to the next patch, 
> or move the call
> to fd_install() here if that is possible? In both cases, the 
> call to get_unused_fd() can be moved right before fd_install() 
> so you don't need to
> call put_unused_fd() in the error paths below.

Aha, just realized that fd_install() was called in qbuf() :) Other comments 
probably still hold though.

>
> ... same thing for sync_file too. Maybe this patch can just be merged into
> the next one? The current patch just creates an incomplete 
> version of vb2_setup_out_fence() for which no user exist yet.
>
>> +
>> +	vb->out_fence = vb2_fence_alloc(q->out_fence_context);
>> +	if (!vb->out_fence) {
>> +		put_unused_fd(vb->out_fence_fd);
>> +		return -ENOMEM; ...
>
>