linux-kernel - Re: [PATCH v1 5/5] platform/x86: intel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 17 Nov 2017 15:36:32 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Souvik Kumar Chakravarty <souvik.k.chakravarty@...el.com>
Cc:     Platform Driver <platform-driver-x86@...r.kernel.org>,
        "dvhart@...radead.org" <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Rajneesh Bhardwaj <rajneesh.bhardwaj@...el.com>
Subject: Re: [PATCH v1 5/5] platform/x86: intel_telemetry: Improve S0ix logs

On Thu, Nov 16, 2017 at 12:18 PM, Souvik Kumar Chakravarty
<souvik.k.chakravarty@...el.com> wrote:
> Suspend with shallow wakes is not a useful parameter since the phenomena
> does not exist on deployed devices and is only a parameter of use during
> device power-on phase. The field always reads zero. Additionally there
> are other easier methods to detect it, e.g., if the S0ix counter
> increments by more than one during suspend. Hence the field is superfluous
> and can be removed.
>
> This patch also slightly renames the S0ix total field for better
> viewability.

> -                               (u64)(s0ix_total_res*10/192));
> +                  (u64)(s0ix_total_res*10/192));

Why indentation is changed? Candidate for the patch wrt indentation thingy.

> -       if (suspend_shlw_ctr_exit == 1) {
> +       if (suspend_shlw_ctr_exit > 0) {

How could it be less than 0?

!= 0 ?

> -       if (suspend_deep_ctr_exit == 1) {
> +       if (suspend_deep_ctr_exit > 0) {

Ditto.

-- 
With Best Regards,
Andy Shevchenko