linux-kernel - Re: [PATCH v1 0/5] platform/x86: intel_telemetry: Fix counters and formatting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 17 Nov 2017 15:37:11 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Souvik Kumar Chakravarty <souvik.k.chakravarty@...el.com>
Cc:     Platform Driver <platform-driver-x86@...r.kernel.org>,
        "dvhart@...radead.org" <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Rajneesh Bhardwaj <rajneesh.bhardwaj@...el.com>
Subject: Re: [PATCH v1 0/5] platform/x86: intel_telemetry: Fix counters and formatting

On Thu, Nov 16, 2017 at 12:18 PM, Souvik Kumar Chakravarty
<souvik.k.chakravarty@...el.com> wrote:
> This patchset fixes https://bugzilla.kernel.org/show_bug.cgi?id=197833, and
> other issues related to telemetry counters. It also cleans up formatting
> and removes redundanant code.
>
> It is rebased on top of the TESTING branch.

Overall looks not so bad, please address my comments.

>
> Souvik Kumar Chakravarty (5):
>   platform/x86: intel_pmc_ipc: Fix register names
>   platform/x86: intel_telemetry: Fix suspend stats
>   platform/x86: intel_telemetry: Fix local variables
>   platform/x86: intel_telemetry: Remove redundancies
>   platform/x86: intel_telemetry: Improve S0ix logs
>
>  arch/x86/include/asm/intel_pmc_ipc.h           |  10 ++-
>  drivers/platform/x86/intel_pmc_ipc.c           |   4 +-
>  drivers/platform/x86/intel_telemetry_debugfs.c | 101 +++++++++++++------------
>  3 files changed, 59 insertions(+), 56 deletions(-)
>
> --
> 2.7.4
>



-- 
With Best Regards,
Andy Shevchenko