linux-kernel - Re: [PATCH] ntb: remove unneeded DRIVER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOFm3uGa01Zkpc7sDeosB0HSKcqb4gjiQK32wF8aq7VcNAEkZQ@mail.gmail.com>
Date:   Fri, 17 Nov 2017 15:53:49 +0100
From:   Philippe Ombredanne <pombredanne@...b.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Jon Mason <jdmason@...zu.us>, Dave Jiang <dave.jiang@...el.com>,
        Allen Hubbe <Allen.Hubbe@....com>,
        Gary R Hook <gary.hook@....com>,
        Serge Semin <fancer.lancer@...il.com>,
        LKML <linux-kernel@...r.kernel.org>, linux-ntb@...glegroups.com
Subject: Re: [PATCH] ntb: remove unneeded DRIVER_LICENSE #defines

On Fri, Nov 17, 2017 at 3:20 PM, Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
> There is no need to #define the license of the driver, just put it in
> the MODULE_LICENSE() line directly as a text string.
>
> This allows tools that check that the module license matches the source
> code license to work properly, as there is no need to unwind the
> unneeded dereference, especially when the string is defined just a few
> lines above the usage of it.
>
> Cc: Jon Mason <jdmason@...zu.us>
> Cc: Dave Jiang <dave.jiang@...el.com>
> Cc: Allen Hubbe <Allen.Hubbe@....com>
> Cc: Gary R Hook <gary.hook@....com>
> Cc: Serge Semin <fancer.lancer@...il.com>
> Reported-by: Philippe Ombredanne <pombredanne@...b.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>


Reviewed-by: Philippe Ombredanne <pombredanne@...b.com>
-- 
Cordially
Philippe Ombredanne