linux-kernel - Re: [PATCH] ntb: remove unneeded DRIVER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 27 Nov 2017 11:15:24 -0500
From:   Jon Mason <jdmason@...zu.us>
To:     Philippe Ombredanne <pombredanne@...b.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Dave Jiang <dave.jiang@...el.com>,
        Allen Hubbe <Allen.Hubbe@....com>,
        Gary R Hook <gary.hook@....com>,
        Serge Semin <fancer.lancer@...il.com>,
        LKML <linux-kernel@...r.kernel.org>, linux-ntb@...glegroups.com
Subject: Re: [PATCH] ntb: remove unneeded DRIVER_LICENSE #defines

On Fri, Nov 17, 2017 at 9:53 AM, Philippe Ombredanne
<pombredanne@...b.com> wrote:
> On Fri, Nov 17, 2017 at 3:20 PM, Greg Kroah-Hartman
> <gregkh@...uxfoundation.org> wrote:
>> There is no need to #define the license of the driver, just put it in
>> the MODULE_LICENSE() line directly as a text string.
>>
>> This allows tools that check that the module license matches the source
>> code license to work properly, as there is no need to unwind the
>> unneeded dereference, especially when the string is defined just a few
>> lines above the usage of it.
>>
>> Cc: Jon Mason <jdmason@...zu.us>
>> Cc: Dave Jiang <dave.jiang@...el.com>
>> Cc: Allen Hubbe <Allen.Hubbe@....com>
>> Cc: Gary R Hook <gary.hook@....com>
>> Cc: Serge Semin <fancer.lancer@...il.com>
>> Reported-by: Philippe Ombredanne <pombredanne@...b.com>
>> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>
>
> Reviewed-by: Philippe Ombredanne <pombredanne@...b.com>

Applied to my ntb-next branch.

Thanks,
Jon

> --
> Cordially
> Philippe Ombredanne