| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <9e0e1b65-337f-4f0e-7e55-6cee8c17a507@osg.samsung.com>
Date: Fri, 17 Nov 2017 08:07:19 -0700
From: Shuah Khan <shuahkh@....samsung.com>
To: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
Peter Zijlstra <peterz@...radead.org>,
"Paul E . McKenney" <paulmck@...ux.vnet.ibm.com>,
Boqun Feng <boqun.feng@...il.com>,
Andy Lutomirski <luto@...capital.net>,
Dave Watson <davejwatson@...com>
Cc: linux-kernel@...r.kernel.org, linux-api@...r.kernel.org,
Paul Turner <pjt@...gle.com>,
Andrew Morton <akpm@...ux-foundation.org>,
Russell King <linux@....linux.org.uk>,
Thomas Gleixner <tglx@...utronix.de>,
Ingo Molnar <mingo@...hat.com>,
"H . Peter Anvin" <hpa@...or.com>, Andrew Hunter <ahh@...gle.com>,
Andi Kleen <andi@...stfloor.org>, Chris Lameter <cl@...ux.com>,
Ben Maurer <bmaurer@...com>,
Steven Rostedt <rostedt@...dmis.org>,
Josh Triplett <josh@...htriplett.org>,
Linus Torvalds <torvalds@...ux-foundation.org>,
Catalin Marinas <catalin.marinas@....com>,
Will Deacon <will.deacon@....com>,
Michael Kerrisk <mtk.manpages@...il.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Maged Michael <maged.michael@...il.com>,
Avi Kivity <avi@...lladb.com>,
Benjamin Herrenschmidt <benh@...nel.crashing.org>,
Paul Mackerras <paulus@...ba.org>,
Michael Ellerman <mpe@...erman.id.au>,
Alan Stern <stern@...land.harvard.edu>,
Andy Lutomirski <luto@...nel.org>,
Alice Ferrazzi <alice.ferrazzi@...il.com>,
Paul Elder <paul.elder@...t.edu>,
linux-kselftest@...r.kernel.org, linux-arch@...r.kernel.org,
Shuah Khan <shuahkh@....samsung.com>,
Shuah Khan <shuah@...nel.org>
Subject: Re: [RFC PATCH for 4.15 19/24] membarrier: selftest: Test shared
expedited cmd
On 11/14/2017 01:04 PM, Mathieu Desnoyers wrote:
> Test the new MEMBARRIER_CMD_SHARED_EXPEDITED and
> MEMBARRIER_CMD_REGISTER_SHARED_EXPEDITED commands.
>
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
> CC: Shuah Khan <shuahkh@....samsung.com>
> CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> CC: Peter Zijlstra <peterz@...radead.org>
> CC: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
> CC: Boqun Feng <boqun.feng@...il.com>
> CC: Andrew Hunter <ahh@...gle.com>
> CC: Maged Michael <maged.michael@...il.com>
> CC: Avi Kivity <avi@...lladb.com>
> CC: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> CC: Paul Mackerras <paulus@...ba.org>
> CC: Michael Ellerman <mpe@...erman.id.au>
> CC: Dave Watson <davejwatson@...com>
> CC: Alan Stern <stern@...land.harvard.edu>
> CC: Will Deacon <will.deacon@....com>
> CC: Andy Lutomirski <luto@...nel.org>
> CC: Alice Ferrazzi <alice.ferrazzi@...il.com>
> CC: Paul Elder <paul.elder@...t.edu>
> CC: linux-kselftest@...r.kernel.org
> CC: linux-arch@...r.kernel.org
> ---
> .../testing/selftests/membarrier/membarrier_test.c | 51 +++++++++++++++++++++-
> 1 file changed, 50 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/membarrier/membarrier_test.c b/tools/testing/selftests/membarrier/membarrier_test.c
> index e6ee73d01fa1..bb9c58072c5c 100644
> --- a/tools/testing/selftests/membarrier/membarrier_test.c
> +++ b/tools/testing/selftests/membarrier/membarrier_test.c
> @@ -132,6 +132,40 @@ static int test_membarrier_private_expedited_success(void)
> return 0;
> }
>
> +static int test_membarrier_register_shared_expedited_success(void)
> +{
> + int cmd = MEMBARRIER_CMD_REGISTER_SHARED_EXPEDITED, flags = 0;
> + const char *test_name = "sys membarrier MEMBARRIER_CMD_REGISTER_SHARED_EXPEDITED";
> +
> + if (sys_membarrier(cmd, flags) != 0) {
> + ksft_exit_fail_msg(
> + "%s test: flags = %d, errno = %d\n",
> + test_name, flags, errno);
> + }
> +
> + ksft_test_result_pass(
> + "%s test: flags = %d\n",
> + test_name, flags);
> + return 0;
> +}
> +
> +static int test_membarrier_shared_expedited_success(void)
> +{
> + int cmd = MEMBARRIER_CMD_SHARED_EXPEDITED, flags = 0;
> + const char *test_name = "sys membarrier MEMBARRIER_CMD_SHARED_EXPEDITED";
> +
> + if (sys_membarrier(cmd, flags) != 0) {
> + ksft_exit_fail_msg(
> + "%s test: flags = %d, errno = %d\n",
> + test_name, flags, errno);
> + }
> +
> + ksft_test_result_pass(
> + "%s test: flags = %d\n",
> + test_name, flags);
> + return 0;
> +}
> +
> static int test_membarrier(void)
> {
> int status;
> @@ -154,6 +188,19 @@ static int test_membarrier(void)
> status = test_membarrier_private_expedited_success();
> if (status)
> return status;
> + /*
> + * It is valid to send a shared membarrier from a non-registered
> + * process.
> + */
> + status = test_membarrier_shared_expedited_success();
> + if (status)
> + return status;
> + status = test_membarrier_register_shared_expedited_success();
> + if (status)
> + return status;
> + status = test_membarrier_shared_expedited_success();
> + if (status)
> + return status;
> return 0;
> }
>
> @@ -173,8 +220,10 @@ static int test_membarrier_query(void)
> }
> ksft_exit_fail_msg("sys_membarrier() failed\n");
> }
> - if (!(ret & MEMBARRIER_CMD_SHARED))
> + if (!(ret & MEMBARRIER_CMD_SHARED)) {
> + ksft_test_result_fail("sys_membarrier() CMD_SHARED query failed\n");
> ksft_exit_fail_msg("sys_membarrier is not supported.\n");
> + }
>
> ksft_test_result_pass("sys_membarrier available\n");
> return 0;
>
Looks good to me. I am assuming this patch goes in with the rest of the
series. For this patch:
Acked-by: Shuah Khan <shuahkh@....samsung.com>
thanks,
-- Shuah
Powered by blists - more mailing lists