linux-kernel - Re: [RFC PATCH for 4.15 23/24] membarrier: selftest: Test private expedited sync core cmd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 17 Nov 2017 08:09:16 -0700
From:   Shuah Khan <shuahkh@....samsung.com>
To:     Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
        Peter Zijlstra <peterz@...radead.org>,
        "Paul E . McKenney" <paulmck@...ux.vnet.ibm.com>,
        Boqun Feng <boqun.feng@...il.com>,
        Andy Lutomirski <luto@...capital.net>,
        Dave Watson <davejwatson@...com>
Cc:     linux-kernel@...r.kernel.org, linux-api@...r.kernel.org,
        Paul Turner <pjt@...gle.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Russell King <linux@....linux.org.uk>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H . Peter Anvin" <hpa@...or.com>, Andrew Hunter <ahh@...gle.com>,
        Andi Kleen <andi@...stfloor.org>, Chris Lameter <cl@...ux.com>,
        Ben Maurer <bmaurer@...com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Josh Triplett <josh@...htriplett.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>,
        Michael Kerrisk <mtk.manpages@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Maged Michael <maged.michael@...il.com>,
        Avi Kivity <avi@...lladb.com>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        Alan Stern <stern@...land.harvard.edu>,
        Andy Lutomirski <luto@...nel.org>,
        Alice Ferrazzi <alice.ferrazzi@...il.com>,
        Paul Elder <paul.elder@...t.edu>,
        linux-kselftest@...r.kernel.org, linux-arch@...r.kernel.org,
        Shuah Khan <shuahkh@....samsung.com>,
        Shuah Khan <shuah@...nel.org>
Subject: Re: [RFC PATCH for 4.15 23/24] membarrier: selftest: Test private
 expedited sync core cmd

On 11/14/2017 01:04 PM, Mathieu Desnoyers wrote:
> Test the new MEMBARRIER_CMD_PRIVATE_EXPEDITED_SYNC_CORE and
> MEMBARRIER_CMD_REGISTER_PRIVATE_EXPEDITED_SYNC_CORE commands.
> 
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
> CC: Shuah Khan <shuahkh@....samsung.com>
> CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> CC: Peter Zijlstra <peterz@...radead.org>
> CC: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
> CC: Boqun Feng <boqun.feng@...il.com>
> CC: Andrew Hunter <ahh@...gle.com>
> CC: Maged Michael <maged.michael@...il.com>
> CC: Avi Kivity <avi@...lladb.com>
> CC: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> CC: Paul Mackerras <paulus@...ba.org>
> CC: Michael Ellerman <mpe@...erman.id.au>
> CC: Dave Watson <davejwatson@...com>
> CC: Alan Stern <stern@...land.harvard.edu>
> CC: Will Deacon <will.deacon@....com>
> CC: Andy Lutomirski <luto@...nel.org>
> CC: Alice Ferrazzi <alice.ferrazzi@...il.com>
> CC: Paul Elder <paul.elder@...t.edu>
> CC: linux-kselftest@...r.kernel.org
> CC: linux-arch@...r.kernel.org
> ---
>  .../testing/selftests/membarrier/membarrier_test.c | 73 ++++++++++++++++++++++
>  1 file changed, 73 insertions(+)
> 
> diff --git a/tools/testing/selftests/membarrier/membarrier_test.c b/tools/testing/selftests/membarrier/membarrier_test.c
> index bb9c58072c5c..d9ab8b6ee52e 100644
> --- a/tools/testing/selftests/membarrier/membarrier_test.c
> +++ b/tools/testing/selftests/membarrier/membarrier_test.c
> @@ -132,6 +132,63 @@ static int test_membarrier_private_expedited_success(void)
>  	return 0;
>  }
>  
> +static int test_membarrier_private_expedited_sync_core_fail(void)
> +{
> +	int cmd = MEMBARRIER_CMD_PRIVATE_EXPEDITED_SYNC_CORE, flags = 0;
> +	const char *test_name = "sys membarrier MEMBARRIER_CMD_PRIVATE_EXPEDITED_SYNC_CORE not registered failure";
> +
> +	if (sys_membarrier(cmd, flags) != -1) {
> +		ksft_exit_fail_msg(
> +			"%s test: flags = %d. Should fail, but passed\n",
> +			test_name, flags);
> +	}
> +	if (errno != EPERM) {
> +		ksft_exit_fail_msg(
> +			"%s test: flags = %d. Should return (%d: \"%s\"), but returned (%d: \"%s\").\n",
> +			test_name, flags, EPERM, strerror(EPERM),
> +			errno, strerror(errno));
> +	}
> +
> +	ksft_test_result_pass(
> +		"%s test: flags = %d, errno = %d\n",
> +		test_name, flags, errno);
> +	return 0;
> +}
> +
> +static int test_membarrier_register_private_expedited_sync_core_success(void)
> +{
> +	int cmd = MEMBARRIER_CMD_REGISTER_PRIVATE_EXPEDITED_SYNC_CORE, flags = 0;
> +	const char *test_name = "sys membarrier MEMBARRIER_CMD_REGISTER_PRIVATE_EXPEDITED_SYNC_CORE";
> +
> +	if (sys_membarrier(cmd, flags) != 0) {
> +		ksft_exit_fail_msg(
> +			"%s test: flags = %d, errno = %d\n",
> +			test_name, flags, errno);
> +	}
> +
> +	ksft_test_result_pass(
> +		"%s test: flags = %d\n",
> +		test_name, flags);
> +	return 0;
> +}
> +
> +static int test_membarrier_private_expedited_sync_core_success(void)
> +{
> +	int cmd = MEMBARRIER_CMD_PRIVATE_EXPEDITED, flags = 0;
> +	const char *test_name = "sys membarrier MEMBARRIER_CMD_PRIVATE_EXPEDITED_SYNC_CORE";
> +
> +	if (sys_membarrier(cmd, flags) != 0) {
> +		ksft_exit_fail_msg(
> +			"%s test: flags = %d, errno = %d\n",
> +			test_name, flags, errno);
> +	}
> +
> +	ksft_test_result_pass(
> +		"%s test: flags = %d\n",
> +		test_name, flags);
> +	return 0;
> +}
> +
>  static int test_membarrier_register_shared_expedited_success(void)
>  {
>  	int cmd = MEMBARRIER_CMD_REGISTER_SHARED_EXPEDITED, flags = 0;
> @@ -188,6 +245,22 @@ static int test_membarrier(void)
>  	status = test_membarrier_private_expedited_success();
>  	if (status)
>  		return status;
> +	status = sys_membarrier(MEMBARRIER_CMD_QUERY, 0);
> +	if (status < 0) {
> +		ksft_test_result_fail("sys_membarrier() failed\n");
> +		return status;
> +	}
> +	if (status & MEMBARRIER_CMD_PRIVATE_EXPEDITED_SYNC_CORE) {
> +		status = test_membarrier_private_expedited_sync_core_fail();
> +		if (status)
> +			return status;
> +		status = test_membarrier_register_private_expedited_sync_core_success();
> +		if (status)
> +			return status;
> +		status = test_membarrier_private_expedited_sync_core_success();
> +		if (status)
> +			return status;
> +	}
>  	/*
>  	 * It is valid to send a shared membarrier from a non-registered
>  	 * process.
> 

Looks good to me. I am assuming this patch goes in with the rest of the
series. For this patch:

Acked-by: Shuah Khan <shuahkh@....samsung.com>

thanks,
-- Shuah