linux-kernel - Re: [PATCH] fs: Safe rcu access to hlist.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171119212849.GV21978@ZenIV.linux.org.uk>
Date:   Sun, 19 Nov 2017 21:28:49 +0000
From:   Al Viro <viro@...IV.linux.org.uk>
To:     Tim Hansen <devtimhansen@...il.com>
Cc:     linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH] fs: Safe rcu access to hlist.

On Sun, Nov 19, 2017 at 03:02:10PM -0500, Tim Hansen wrote:
> Adds hlist_first_rcu and hlist_next_rcu for safe access
> to the hlist in seq_hlist_next_rcu.
> 
> Found on linux-next branch, tag next-20171117 with sparse.

Frankly, I'm tempted to take sparse RCU annotations out for good -
they are far too noisy and I'm not sure sparse is suitable for the
analysis needed to prove safety of that stuff, so unless you (or
somebody else) figures out how to use them in a reasonably clean
way, we'd probably be better off just dropping them.