linux-kernel - Re: [PATCH] usbnet: ipheth: fix potential null pointer dereference in ipheth_carrier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171119.122410.1141429840787861663.davem@davemloft.net>
Date:   Sun, 19 Nov 2017 12:24:10 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     garsilva@...eddedor.com
Cc:     linux-usb@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usbnet: ipheth: fix potential null pointer dereference
 in ipheth_carrier_set

From: "Gustavo A. R. Silva" <garsilva@...eddedor.com>
Date: Fri, 17 Nov 2017 14:02:09 -0600

> _dev_ is being dereferenced before it is null checked, hence there
> is a potential null pointer dereference.
> 
> Fix this by moving the pointer dereference after _dev_ has been null
> checked.
> 
> Addresses-Coverity-ID: 1462020
> Fixes: bb1b40c7cb86 ("usbnet: ipheth: prevent TX queue timeouts when device not ready")
> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>

Applied, thanks.