linux-kernel - Re: [PATCH v2 net-next] net/tcp: trace all TCP/IP state transition with tcp_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171119.124053.892184966822585016.davem@davemloft.net>
Date:   Sun, 19 Nov 2017 12:40:53 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     laoar.shao@...il.com
Cc:     kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org, rostedt@...dmis.org,
        songliubraving@...com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 net-next] net/tcp: trace all TCP/IP state transition
 with tcp_set_state tracepoint

From: Yafang Shao <laoar.shao@...il.com>
Date: Sat, 18 Nov 2017 15:32:36 +0000

> The TCP/IP transition from TCP_LISTEN to TCP_SYN_RECV and some other
> transitions are not traced with tcp_set_state tracepoint.
> 
> In order to trace the whole tcp lifespans, two helpers are introduced,
> void __tcp_set_state(struct sock *sk, int state)
> void __sk_state_store(struct sock *sk, int newstate)
> 
> When do TCP/IP state transition, we should use these two helpers or use
> tcp_set_state() other than assigning a value to sk_state directly.
> 
> Signed-off-by: Yafang Shao <laoar.shao@...il.com>

Please resubmit this when the net-next tree opens back up as it is
closed right now.

Thank you.