linux-kernel - Re: [PATCH] Staging: comedi: adl_pci9118.c : fixed code style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <be14fc33-09ad-27bc-3d98-c7807c9a0bcc@mev.co.uk>
Date:   Mon, 20 Nov 2017 11:12:27 +0000
From:   Ian Abbott <abbotti@....co.uk>
To:     Fabian Baumanis <baumanisf@...il.com>, gregkh@...uxfoundation.org
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        hsweeten@...ionengravers.com, larturus@...oo.com
Subject: Re: [PATCH] Staging: comedi: adl_pci9118.c : fixed code style issue

On 18/11/17 17:46, Fabian Baumanis wrote:
> Removed uneccessary parantheses which were sorrounding two
> if-statements.

There is only one 'if' statement changed by the patch.  Apart from that 
(and the typos in the patch description), the patch is fine as far as it 
goes.  However, the checkpatch script identifies several similar 
"unnecessary parentheses" issues in this file, and it would be better to 
take care of them all with a single patch rather than patching them one 
at a time.

> 
> Signed-off-by: Fabian Baumanis <baumanisf@...il.com>
> ---
>   drivers/staging/comedi/drivers/adl_pci9118.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c b/drivers/staging/comedi/drivers/adl_pci9118.c
> index 1cc9b7e..c77b994 100644
> --- a/drivers/staging/comedi/drivers/adl_pci9118.c
> +++ b/drivers/staging/comedi/drivers/adl_pci9118.c
> @@ -946,8 +946,7 @@ static int pci9118_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s)
>          devpriv->ai_add_back = 0;
>          if (devpriv->master) {
>                  devpriv->usedma = 1;
> -               if ((cmd->flags & CMDF_WAKE_EOS) &&
> -                   (cmd->scan_end_arg == 1)) {
> +               if (cmd->flags & CMDF_WAKE_EOS && cmd->scan_end_arg == 1) {
>                          if (cmd->convert_src == TRIG_NOW)
>                                  devpriv->ai_add_back = 1;
>                          if (cmd->convert_src == TRIG_TIMER) {
> 


-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-