linux-kernel - Re: [PATCH] Staging: comedi: adl_pci9118.c : fixed code style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 24 Nov 2017 16:53:55 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Fabian Baumanis <baumanisf@...il.com>
Cc:     abbotti@....co.uk, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, hsweeten@...ionengravers.com,
        larturus@...oo.com
Subject: Re: [PATCH] Staging: comedi: adl_pci9118.c : fixed code style issue

On Sat, Nov 18, 2017 at 06:46:38PM +0100, Fabian Baumanis wrote:
> Removed uneccessary parantheses which were sorrounding two
> if-statements.
> 
> Signed-off-by: Fabian Baumanis <baumanisf@...il.com>
> ---
>  drivers/staging/comedi/drivers/adl_pci9118.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c b/drivers/staging/comedi/drivers/adl_pci9118.c
> index 1cc9b7e..c77b994 100644
> --- a/drivers/staging/comedi/drivers/adl_pci9118.c
> +++ b/drivers/staging/comedi/drivers/adl_pci9118.c
> @@ -946,8 +946,7 @@ static int pci9118_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s)
>         devpriv->ai_add_back = 0;
>         if (devpriv->master) {
>                 devpriv->usedma = 1;
> -               if ((cmd->flags & CMDF_WAKE_EOS) &&
> -                   (cmd->scan_end_arg == 1)) {
> +               if (cmd->flags & CMDF_WAKE_EOS && cmd->scan_end_arg == 1) {

Ick, no, now I need to remember which has higher precedence, "&" or
"&&".  It's "&" right?  I should not have to go look it up.

The code as-is is just fine.

thanks,

greg k-h