linux-kernel - Re: [PATCH] intel_ips: Convert timers to use timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGXu5jKfqs59CpPq9FFS+xTePQ7iWXxGE7TZWQSxEox0ugV_ew@mail.gmail.com>
Date:   Mon, 20 Nov 2017 11:46:05 -0800
From:   Kees Cook <keescook@...omium.org>
To:     Darren Hart <dvhart@...radead.org>
Cc:     Andy Shevchenko <andy.shevchenko@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Andy Shevchenko <andy@...radead.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] intel_ips: Convert timers to use timer_setup()

On Mon, Nov 20, 2017 at 11:45 AM, Darren Hart <dvhart@...radead.org> wrote:
> On Fri, Nov 17, 2017 at 05:30:48PM -0800, Kees Cook wrote:
>> On Fri, Nov 3, 2017 at 5:26 AM, Andy Shevchenko
>> <andy.shevchenko@...il.com> wrote:
>> > On Thu, Nov 2, 2017 at 9:55 PM, Kees Cook <keescook@...omium.org> wrote:
>> >> On Thu, Oct 5, 2017 at 1:41 AM, Andy Shevchenko
>> >> <andy.shevchenko@...il.com> wrote:
>> >>> On Thu, Oct 5, 2017 at 3:54 AM, Kees Cook <keescook@...omium.org> wrote:
>> >>>> In preparation for unconditionally passing the struct timer_list pointer to
>> >>>> all timer callbacks, switch to using the new timer_setup() and from_timer()
>> >>>> to pass the timer pointer explicitly. Moves timer structure off stack and
>> >>>> into struct ips_driver.
>> >>>
>> >>> Pushed to my testing queue, thanks!
>> >>
>> >> Hi,
>> >>
>> >> I don't see this in -next yet. Should the tip tree carry this conversion?
>> >
>> > I thought it was a result of discussion since we lack of patch that
>> > brought the core change.
>> >
>> > However, because I merged Wolfram's immutable branch in order to apply
>> > Hans' fix, I can carry your patch as well.
>> >
>> > Either would be fine with me.
>> >
>> > Going ahead, I applied it to my review and testing queue, thanks!
>>
>> Hi again!
>>
>> I'm just checking on this patch -- I haven't seen it in a pull request
>> to Linus yet (for the merge window he's threatened will be small).
>> This is one of the remaining conversion patches I need in v4.15. Is
>> this still planned to be merged for v4.15?
>
> Hi Kees,
>
> It went out the day after your note above in the platform-drivers-x86-v4.15-1
> pull request. We're working through some issues with this pull request with
> Linus now, but yes, it will make 4.15.

Awesome, thanks! I see it in the tree now. Yay! :)

-Kees

-- 
Kees Cook
Pixel Security