linux-kernel - Re: [PATCH v1 8/9] perf stat: Remove --per-thread pid/tid limitation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <89ea1f20-003e-59dc-1666-a2b74206c08e@linux.intel.com>
Date:   Wed, 22 Nov 2017 11:42:05 +0800
From:   "Jin, Yao" <yao.jin@...ux.intel.com>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     acme@...nel.org, jolsa@...nel.org, peterz@...radead.org,
        mingo@...hat.com, alexander.shishkin@...ux.intel.com,
        Linux-kernel@...r.kernel.org, ak@...ux.intel.com,
        kan.liang@...el.com, yao.jin@...el.com
Subject: Re: [PATCH v1 8/9] perf stat: Remove --per-thread pid/tid limitation



On 11/21/2017 11:18 PM, Jiri Olsa wrote:
> On Mon, Nov 20, 2017 at 10:43:43PM +0800, Jin Yao wrote:
> 
> SNIP
> 
>> -	if ((stat_config.aggr_mode == AGGR_THREAD) && !target__has_task(&target)) {
>> -		fprintf(stderr, "The --per-thread option is only available "
>> -			"when monitoring via -p -t options.\n");
>> -		parse_options_usage(NULL, stat_options, "p", 1);
>> -		parse_options_usage(NULL, stat_options, "t", 1);
>> -		goto out;
>> +	if ((stat_config.aggr_mode == AGGR_THREAD) &&
>> +		!target__has_task(&target)) {
>> +		if (!target.system_wide || target.cpu_list) {
>> +			fprintf(stderr, "The --per-thread option is only "
>> +				"available when monitoring via -p -t "
>> +				"options.\n");
> 
> the message should be updated with '-a' option, that you just added,

OK. Could I update the message like this?

"The --per-thread option is only "
"available when monitoring via -p -t -a"
"options or only --per-thread without any other option"

> also why dont we support target.cpu_list, it should work no?
>

Currently it doesn't support cpu_list.

I just think this patch series is too big and I wish to add supporting 
for cpu_list, cgroup or others in follow up patches.

Is that OK?

Thanks
Jin Yao
> jirka
>