linux-kernel - [PATCH] 4.15 vmgfx boot warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <c845316e-c0f8-9ef7-2bf5-97418d8094c7@gmail.com>
Date:   Wed, 22 Nov 2017 16:05:50 -0500
From:   Woody Suwalski <terraluna977@...il.com>
To:     Sinclair Yeh <syeh@...are.com>
Cc:     DRI mailing list <dri-devel@...ts.freedesktop.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Dave Airlie <airlied@...ux.ie>
Subject: [PATCH] 4.15 vmgfx boot warning

The 4.15 vmwgfx driver shows a warning during boot (32 bit x86)
It is caused by a mismatch between the result of vmw_enable_vblank() and 
what the drm_atomic_helper expects:
    /...
    ret = drm_crtc_vblank_get(crtc);
    WARN_ONCE(ret != -EINVAL, "driver forgot to call 
drm_crtc_vblank_off()\n");
    /...

Signed-off by: Woody Suwalski <terraluna977@...il.com>

--- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c    2017-11-22 
15:29:46.511674079 -0500
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c    2017-11-22 
15:30:35.344559592 -0500
@@ -1869,7 +1869,7 @@ u32 vmw_get_vblank_counter(struct drm_de
   */
  int vmw_enable_vblank(struct drm_device *dev, unsigned int pipe)
  {
-    return -ENOSYS;
+    return -EINVAL;
  }

  /**