linux-kernel - Re: [PATCH v3] kbuild: Set KBUILD_CFLAGS before incl. arch Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNASGYZfQFkM3yMRQaHLUwW5Lhp8CxHGX0bJ9sVja0f=n+A@mail.gmail.com>
Date:   Thu, 23 Nov 2017 13:24:09 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Nick Desaulniers <ndesaulniers@...gle.com>
Cc:     Behan Webster <behanw@...verseincode.com>,
        Jan-Simon Möller <dl9pf@....de>,
        Mark Charlebois <charlebm@...il.com>,
        Greg Hackmann <ghackmann@...gle.com>,
        Matthias Kaehlcke <mka@...omium.org>,
        Douglas Anderson <dianders@...omium.org>,
        Chris Fries <cfries@...gle.com>,
        Michal Marek <mmarek@...e.com>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] kbuild: Set KBUILD_CFLAGS before incl. arch Makefile

Hi.

2017-11-18 13:09 GMT+09:00 Masahiro Yamada <yamada.masahiro@...ionext.com>:
> 2017-11-16 5:42 GMT+09:00 Nick Desaulniers <ndesaulniers@...gle.com>:
>> From: Chris Fries <cfries@...gle.com>
>>
>> Set the clang KBUILD_CFLAGS up before including arch/ Makefiles,
>> so that ld-options (etc.) can work correctly.
>>
>> This fixes errors with clang such as ld-options trying to CC
>> against your host architecture, but LD trying to link against
>> your target architecture.
>>
>> Reviewed-by: Matthias Kaehlcke <mka@...omium.org>
>> Signed-off-by: Chris Fries <cfries@...gle.com>
>> Signed-off-by: Nick Desaulniers <ndesaulniers@...gle.com>
>> Suggested-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
>> Tested-by: Matthias Kaehlcke <mka@...omium.org>
>> ---
>
> Applied to linux-kbuild/kbuild.  Thanks!
>
> --
> Best Regards
> Masahiro Yamada

After more thought, I picked up your v2.
(clang variables before kernel configuration)

Linus suggests to move compiler flag testing to Kconfig.
To do it, we need to feed target CC information to Kconfig.

Sorry for spending your time.


-- 
Best Regards
Masahiro Yamada