linux-kernel - Stack switching plan of attack (Re: [PATCH v2 00/18] Entry stack switching)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALCETrXmRyyX7LpYd29R+vX0cMHDEjTzyK_0JCDYU01CgL82kQ@mail.gmail.com>
Date:   Thu, 23 Nov 2017 07:50:59 -0800
From:   Andy Lutomirski <luto@...nel.org>
To:     Andy Lutomirski <luto@...nel.org>
Cc:     X86 ML <x86@...nel.org>, Borislav Petkov <bpetkov@...e.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Brian Gerst <brgerst@...il.com>,
        Dave Hansen <dave.hansen@...el.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Josh Poimboeuf <jpoimboe@...hat.com>
Subject: Stack switching plan of attack (Re: [PATCH v2 00/18] Entry stack switching)

On Tue, Nov 21, 2017 at 8:43 PM, Andy Lutomirski <luto@...nel.org> wrote:
> This sets up stack switching, including for SYSCALL.  I think it's
> in decent shape.

What's the plan of attack?  is the goal to get this thing in -rc1 or
as soon as possible thereafter?

If so, I think there are two things that need fixing to make it upstream-worthy:

1. There needs to be a way to turn it off to get the performance hit
under control.  I'm leaning toward a boot-time switch, and we can turn
it into a runtime switch later on.  Thoughts?  I don't care too much
about idtentry performance, but syscall performance matters a lot, and
my patches slow it down.  I probably need to benchmark to see whether
there's any point to turning *entry* stack switching off, but we
definitely need to turn *exit* stack switching off when it's not
needed.

(Entry stack switching doesn't directly affect SYSCALL, and I've
structured the SYSCALL code so that the entry part can be turned on
and off just by changing the entry target MSR.)

2. The TSS should be RO.  Otherwise I think it's just too big a
security regression.

and possibly 3: fix the existing performance regression on Atom
syscalls.  That's easy-ish, but it's ugly and stupid.

I'm assuming that KAISER itself will miss the merge window and that
we'll just deal with it.