linux-kernel - Re: [dm-devel] [PATCH 3/4] dm: convert dm_dev_internal.count from atomic_t to refcount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171123154941.GA15790@agk-dp.fab.redhat.com>
Date:   Thu, 23 Nov 2017 15:49:41 +0000
From:   Alasdair G Kergon <agk@...hat.com>
To:     Elena Reshetova <elena.reshetova@...el.com>
Cc:     dm-devel@...hat.com, keescook@...omium.org, snitzer@...hat.com,
        peterz@...radead.org, shli@...nel.org, koverstreet@...gle.com,
        linux-kernel@...r.kernel.org, linux-raid@...r.kernel.org,
        linux-bcache@...r.kernel.org, ejt@...hat.comg,
        kent.overstreet@...il.com, agk@...hat.com,
        Zdenek Kabelac <zkabelac@...hat.com>
Subject: Re: [dm-devel] [PATCH 3/4] dm: convert dm_dev_internal.count from
        atomic_t to refcount_t

On Fri, Oct 20, 2017 at 10:37:38AM +0300, Elena Reshetova wrote:
>  	} else if (dd->dm_dev->mode != (mode | dd->dm_dev->mode)) {
>  		r = upgrade_mode(dd, mode, t->md);
>  		if (r)
>  			return r;
> +		refcount_inc(&dd->count);
>  	}

Missing here:

        else
		refcount_inc(&dd->count);

?

Alasdair