linux-kernel - RE: [dm-devel] [PATCH 3/4] dm: convert dm_dev_internal.count from atomic_t to refcount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2236FBA76BA1254E88B949DDB74E612B802C1F07@IRSMSX102.ger.corp.intel.com>
Date:   Fri, 24 Nov 2017 07:36:26 +0000
From:   "Reshetova, Elena" <elena.reshetova@...el.com>
To:     Alasdair G Kergon <agk@...hat.com>
CC:     "dm-devel@...hat.com" <dm-devel@...hat.com>,
        "keescook@...omium.org" <keescook@...omium.org>,
        "snitzer@...hat.com" <snitzer@...hat.com>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "shli@...nel.org" <shli@...nel.org>,
        "koverstreet@...gle.com" <koverstreet@...gle.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-raid@...r.kernel.org" <linux-raid@...r.kernel.org>,
        "linux-bcache@...r.kernel.org" <linux-bcache@...r.kernel.org>,
        "ejt@...hat.comg" <ejt@...hat.comg>,
        "kent.overstreet@...il.com" <kent.overstreet@...il.com>,
        Zdenek Kabelac <zkabelac@...hat.com>
Subject: RE: [dm-devel] [PATCH 3/4] dm: convert dm_dev_internal.count from
        atomic_t to refcount_t

> On Fri, Oct 20, 2017 at 10:37:38AM +0300, Elena Reshetova wrote:
> >  	} else if (dd->dm_dev->mode != (mode | dd->dm_dev->mode)) {
> >  		r = upgrade_mode(dd, mode, t->md);
> >  		if (r)
> >  			return r;
> > +		refcount_inc(&dd->count);
> >  	}
> 
> Missing here:
> 
>         else
> 		refcount_inc(&dd->count);
> 
> ?

Oh, yes, thanks for catching this! I think this got unnoticed so far and patch was merged, so I am going to send a followup patch now. 

Best Regards,
Elena.

> 
> Alasdair