linux-kernel - Re: [PATCH] video/fbdev/stifb: Delete an error message for a failed memory allocation in stifb_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <25624997.nONnEdNj0s@daneel.sf-tec.de>
Date:   Fri, 24 Nov 2017 22:30:34 +0100
From:   Rolf Eike Beer <eike-kernel@...tec.de>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:     dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org,
        linux-parisc@...r.kernel.org,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Helge Deller <deller@....de>,
        "James E. J. Bottomley" <jejb@...isc-linux.org>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] video/fbdev/stifb: Delete an error message for a failed memory allocation in stifb_init_fb()

Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Fri, 24 Nov 2017 22:22:06 +0100
> 
> Omit an extra message for a memory allocation failure in this function.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>  drivers/video/fbdev/stifb.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/video/fbdev/stifb.c b/drivers/video/fbdev/stifb.c
> index 6ded5c198998..fe217a2f7d21 100644
> --- a/drivers/video/fbdev/stifb.c
> +++ b/drivers/video/fbdev/stifb.c
> @@ -1126,10 +1126,8 @@ static int __init stifb_init_fb(struct sti_struct
> *sti, int bpp_pref) int bpp, xres, yres;
> 
>  	fb = kzalloc(sizeof(*fb), GFP_ATOMIC);
> -	if (!fb) {
> -		printk(KERN_ERR "stifb: Could not allocate stifb structure\n");
> +	if (!fb)
>  		return -ENODEV;
> -	}
> 
>  	info = &fb->info;

This should be -ENOMEM.

Eike
Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)