linux-kernel - Re: [PATCH v6 07/11] intel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171126165321.ldpnudpiqyjsuv3v@linux.intel.com>
Date:   Sun, 26 Nov 2017 18:53:21 +0200
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     Joe Perches <joe@...ches.com>
Cc:     platform-driver-x86@...r.kernel.org, x86@...nel.org,
        linux-kernel@...r.kernel.org, Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>
Subject: Re: [PATCH v6 07/11] intel_sgx: ptrace() support

On Sun, Nov 26, 2017 at 07:50:05AM -0800, Joe Perches wrote:
> On Sun, 2017-11-26 at 17:44 +0200, Jarkko Sakkinen wrote:
> > On Sat, Nov 25, 2017 at 09:29:24PM +0200, Jarkko Sakkinen wrote:
> > > +	ptr = sgx_get_page(page->epc_page);
> > > +	ret = __edbgrd((unsigned long)ptr + offset, data);
> 	        ^^^^^^
> 
> > > +	sgx_put_page(ptr);
> > > +	if (ret) {
> > > +		sgx_dbg(encl, "EDBGRD returned %d\n", ret);
> >                                ~~~~~~
> > 			       EDBGWR
> 
> ?

D'oh I meant to quote this part:

	ptr = sgx_get_page(page->epc_page);
	ret = __edbgwr((unsigned long)ptr + offset, data);
	sgx_put_page(ptr);
	if (ret) {
		sgx_dbg(encl, "EDBGRD returned %d\n", ret);
		return -EFAULT;
	}

There's a typo in sgx_dbg().

/Jarkko