linux-kernel - Re: [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86f3f594-79f7-c2ce-2cc6-f641bd6f55ae@deltatee.com>
Date:   Sun, 26 Nov 2017 23:40:16 -0700
From:   Logan Gunthorpe <logang@...tatee.com>
To:     Julia Lawall <julia.lawall@...6.fr>
Cc:     Joe Perches <joe@...ches.com>, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org, Andy Whitcroft <apw@...onical.com>
Subject: Re: [PATCH v2] checkpatch: Add a warning for log messages that don't
 end in a new line

On 26/11/17 11:34 PM, Julia Lawall wrote:
> It would probably be better not to mention the KERN_CONT possibility at
> all.

Oh? I don't disagree... but what are we supposed to do in these cases?
The way v2 of my patch works it just says that there is a missing new
line. But Joe calls that a false positive. So if we can't report that
it's missing a new line and we can't say it looks like it needs a
KERN_CONT, then what can we do? The case is obviously wrong in some way
or another so we probably shouldn't just ignore it.

Logan