linux-kernel - Re: [PATCH v2] quota: propagate error from __dquot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171127155647.GD5977@quack2.suse.cz>
Date:   Mon, 27 Nov 2017 16:56:47 +0100
From:   Jan Kara <jack@...e.cz>
To:     Chao Yu <chao@...nel.org>
Cc:     jack@...e.com, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, Chao Yu <yuchao0@...wei.com>
Subject: Re: [PATCH v2] quota: propagate error from __dquot_initialize

On Thu 23-11-17 23:21:01, Chao Yu wrote:
> @@ -2364,10 +2370,11 @@ static int vfs_load_quota_inode(struct inode *inode, int type, int format_id,
>  	dqopt->flags |= dquot_state_flag(flags, type);
>  	spin_unlock(&dq_state_lock);
>  
> -	add_dquot_ref(sb, type);
> -
> -	return 0;
> +	error = add_dquot_ref(sb, type);
> +	if (error)
> +		dquot_disable(sb, type, dqopt->flags);

Why dqopt->flags? If anything these flags are shifted by user/group/project
shift and combined together for all the types. You need to just pass
'flags' here. Other than that the patch looks good.

								Honza
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR