linux-kernel - Re: [PATCH v2] quota: propagate error from __dquot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 28 Nov 2017 22:58:02 +0800
From:   Chao Yu <chao@...nel.org>
To:     Jan Kara <jack@...e.cz>
Cc:     jack@...e.com, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, Chao Yu <yuchao0@...wei.com>
Subject: Re: [PATCH v2] quota: propagate error from __dquot_initialize

On 2017/11/27 23:56, Jan Kara wrote:
> On Thu 23-11-17 23:21:01, Chao Yu wrote:
>> @@ -2364,10 +2370,11 @@ static int vfs_load_quota_inode(struct inode *inode, int type, int format_id,
>>  	dqopt->flags |= dquot_state_flag(flags, type);
>>  	spin_unlock(&dq_state_lock);
>>  
>> -	add_dquot_ref(sb, type);
>> -
>> -	return 0;
>> +	error = add_dquot_ref(sb, type);
>> +	if (error)
>> +		dquot_disable(sb, type, dqopt->flags);
> 
> Why dqopt->flags? If anything these flags are shifted by user/group/project

Oh, correct, user/group/project type quota flags are shifted and merged into
dqopt->flags.... just notice that, sorry.

Let me update the patch. :)

Thanks,

> shift and combined together for all the types. You need to just pass
> 'flags' here. Other than that the patch looks good.
> 
> 								Honza
>