linux-kernel - Re: [PATCH] firmware: raspberrypi: print time using time64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87609vlmls.fsf@anholt.net>
Date:   Mon, 27 Nov 2017 08:20:31 -0800
From:   Eric Anholt <eric@...olt.net>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     y2038@...ts.linaro.org, Stefan Wahren <stefan.wahren@...e.com>,
        linux-rpi-kernel@...ts.infradead.org,
        Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] firmware: raspberrypi: print time using time64_t

Arnd Bergmann <arnd@...db.de> writes:

> The firmware timestamp is an unsigned 32-bit value, but we copy it into
> a signed 32-bit variable, so we can theoretically get an overflow in
> the calculation when the timestamp is between 2038 and 2106.
>
> This changes the temporary variable to time64_t and changes the deprecated
> time_to_tm() over to time64_to_tm() accordingly.
>
> There is still an overflow in y2106, but that is a limitation of the
> firmware interface, not a kernel problem.

Reviewed-by: Eric Anholt <eric@...olt.net>

I'll pull this in our branches.

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)