linux-kernel - Re: [PATCH] arm64: fix missing 'const' qualifiers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKwvOdm+65Fx1gLZR3h7Vz-Ma4DNWR4W=cOL8KpKZXMgN-nCLg@mail.gmail.com>
Date:   Mon, 27 Nov 2017 09:15:50 -0800
From:   Nick Desaulniers <ndesaulniers@...gle.com>
To:     Yury Norov <ynorov@...iumnetworks.com>
Cc:     linux-arm-kernel@...ts.infradead.org,
        LKML <linux-kernel@...r.kernel.org>,
        Alex Matveev <alxmtvv@...il.com>,
        Alexander Potapenko <glider@...gle.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Kees Cook <keescook@...omium.org>,
        Mark Rutland <mark.rutland@....com>,
        Maxim Kuvyrkov <maxim.kuvyrkov@...aro.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Sami Tolvanen <samitolvanen@...gle.com>,
        Stephen Boyd <sboyd@...eaurora.org>,
        Will Deacon <will.deacon@....com>
Subject: Re: [PATCH] arm64: fix missing 'const' qualifiers

Checked call sites, looks like no one tries to modify these pointers.
I too prefer to make things as const as possible, though I recently
had a coworker refer to the propagation of const in a code base as a
"Gordian knot," which I thought was eloquent.

checkpatch mentions that there's one line that's over 80 chars, and
that there's M$ DOS style line endings (but that may just be my client
gmail, or yours (exchange?)).  If you fix up that long line, then:

Reviewed-by: Nick Desaulniers <ndesaulniers@...gle.com>