linux-kernel - Re: [PATCH] arm64: fix missing 'const' qualifiers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 27 Nov 2017 20:59:19 +0300
From:   Yury Norov <ynorov@...iumnetworks.com>
To:     Nick Desaulniers <ndesaulniers@...gle.com>
Cc:     linux-arm-kernel@...ts.infradead.org,
        LKML <linux-kernel@...r.kernel.org>,
        Alex Matveev <alxmtvv@...il.com>,
        Alexander Potapenko <glider@...gle.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Kees Cook <keescook@...omium.org>,
        Mark Rutland <mark.rutland@....com>,
        Maxim Kuvyrkov <maxim.kuvyrkov@...aro.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Sami Tolvanen <samitolvanen@...gle.com>,
        Stephen Boyd <sboyd@...eaurora.org>,
        Will Deacon <will.deacon@....com>,
        Joe Perches <joe@...ches.com>,
        Andy Whitcroft <apw@...onical.com>
Subject: Re: [PATCH] arm64: fix missing 'const' qualifiers

On Mon, Nov 27, 2017 at 09:15:50AM -0800, Nick Desaulniers wrote:
> Checked call sites, looks like no one tries to modify these pointers.
> I too prefer to make things as const as possible, though I recently
> had a coworker refer to the propagation of const in a code base as a
> "Gordian knot," which I thought was eloquent.
>
> checkpatch mentions that there's one line that's over 80 chars, and
> that there's M$ DOS style line endings (but that may just be my client
> gmail, or yours (exchange?)).  If you fix up that long line, then:

I happily use mutt, but my company's mail server is MS Outlook, so I 
have to send everything with msmtp. It usually works. In fact, this
is the first complain for 2 years. 

My checkpatch:
yury:linux$ scripts/checkpatch.pl const.patch 
total: 0 errors, 0 warnings, 32 lines checked

const.patch has no obvious style problems and is ready for submission.

I guess, because 1 line is exactly 80 chars length, and because MS format
adds another symbol as line delimiter, we end up with 81 chars in line,
which makes checkpatch worrying.

CC Joe Perches and Andy Whitcroft for it.

> Reviewed-by: Nick Desaulniers <ndesaulniers@...gle.com>

Thanks