linux-kernel - Re: [PATCH] i2c: i2c-boardinfo: fix memory leaks on devinfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171127181452.c3cokz2ejqmhazfa@ninjato>
Date:   Mon, 27 Nov 2017 19:14:52 +0100
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Colin King <colin.king@...onical.com>
Cc:     linux-i2c@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: i2c-boardinfo: fix memory leaks on devinfo

On Wed, Nov 22, 2017 at 05:52:24PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Currently when an error occurs devinfo is still allocated but is
> unused when the error exit paths break out of the for-loop. Fix
> this by kfree'ing devinfo to avoid the leak.
> 
> Detected by CoverityScan, CID#1416590 ("Resource Leak")
> 
> Fixes: 4124c4eba402 ("i2c: allow attaching IRQ resources to i2c_board_info")
> Fixes: 0daaf99d8424 ("i2c: copy device properties when using i2c_register_board_info()")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied to for-current, thanks!


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)