Message-ID: <001a113ebb5ece8a7a055efb7676@google.com>
Date:   Mon, 27 Nov 2017 10:56:46 -0800
From:   syzbot 
        <bot+6fbc13c3b1ed2105e7a2e516be43d6a0624a59c0@...kaller.appspotmail.com>
To:     davem@...emloft.net, herbert@...dor.apana.org.au,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        syzkaller-bugs@...glegroups.com
Subject: KASAN: use-after-free Read in aead_recvmsg

Hello,

syzkaller hit the following crash on  
6fc478f80f6809cc4b1a4230f47a62d3b7378dc0
git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master
compiler: gcc (GCC) 7.1.1 20170620
.config is attached
Raw console output is attached.
C reproducer is attached
syzkaller reproducer is attached. See https://goo.gl/kgGztJ
for information about syzkaller reproducers


==================================================================
BUG: KASAN: use-after-free in skcipher_request_set_tfm  
include/crypto/skcipher.h:499 [inline]
BUG: KASAN: use-after-free in crypto_aead_copy_sgl crypto/algif_aead.c:85  
[inline]
BUG: KASAN: use-after-free in _aead_recvmsg crypto/algif_aead.c:210 [inline]
BUG: KASAN: use-after-free in aead_recvmsg+0x1552/0x1970  
crypto/algif_aead.c:313
Read of size 4 at addr ffff8801c7194e5c by task syzkaller438416/3340

CPU: 0 PID: 3340 Comm: syzkaller438416 Not tainted 4.14.0-next-20171124+ #51
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS  
Google 01/01/2011
Call Trace:
  __dump_stack lib/dump_stack.c:17 [inline]
  dump_stack+0x194/0x257 lib/dump_stack.c:53
  print_address_description+0x73/0x250 mm/kasan/report.c:252
  kasan_report_error mm/kasan/report.c:351 [inline]
  kasan_report+0x25b/0x340 mm/kasan/report.c:409
  __asan_report_load4_noabort+0x14/0x20 mm/kasan/report.c:429
  skcipher_request_set_tfm include/crypto/skcipher.h:499 [inline]
  crypto_aead_copy_sgl crypto/algif_aead.c:85 [inline]
  _aead_recvmsg crypto/algif_aead.c:210 [inline]
  aead_recvmsg+0x1552/0x1970 crypto/algif_aead.c:313
  sock_recvmsg_nosec net/socket.c:805 [inline]
  sock_recvmsg+0xc9/0x110 net/socket.c:812
  ___sys_recvmsg+0x29b/0x630 net/socket.c:2207
  __sys_recvmsg+0xe2/0x210 net/socket.c:2252
  SYSC_recvmsg net/socket.c:2264 [inline]
  SyS_recvmsg+0x2d/0x50 net/socket.c:2259
  entry_SYSCALL_64_fastpath+0x1f/0x96
RIP: 0033:0x44a6f9
RSP: 002b:00007fe979ff6dc8 EFLAGS: 00000202 ORIG_RAX: 000000000000002f
RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 000000000044a6f9
RDX: 0000000000000040 RSI: 00000000207e0000 RDI: 0000000000000006
RBP: 0000000000000086 R08: 00007fe979ff7700 R09: 00007fe979ff7700
R10: 00007fe979ff7700 R11: 0000000000000202 R12: 0000000000000000
R13: 00007ffedba0d74f R14: 00007fe979ff79c0 R15: 0000000000000000

Allocated by task 3242:
  save_stack+0x43/0xd0 mm/kasan/kasan.c:447
  set_track mm/kasan/kasan.c:459 [inline]
  kasan_kmalloc+0xad/0xe0 mm/kasan/kasan.c:551
  __do_kmalloc mm/slab.c:3712 [inline]
  __kmalloc+0x162/0x760 mm/slab.c:3721
  kmalloc include/linux/slab.h:519 [inline]
  kzalloc include/linux/slab.h:703 [inline]
  crypto_create_tfm+0x82/0x2e0 crypto/api.c:455
  crypto_alloc_tfm+0x10e/0x2f0 crypto/api.c:540
  crypto_alloc_skcipher+0x2c/0x40 crypto/skcipher.c:926
  crypto_get_default_null_skcipher+0x5f/0x80 crypto/crypto_null.c:164
  crypto_get_default_null_skcipher2 include/crypto/null.h:17 [inline]
  aead_bind+0x89/0x140 crypto/algif_aead.c:472
  alg_bind+0x1ab/0x440 crypto/af_alg.c:179
  SYSC_bind+0x1b4/0x3f0 net/socket.c:1475
  SyS_bind+0x24/0x30 net/socket.c:1461
  entry_SYSCALL_64_fastpath+0x1f/0x96

Freed by task 3261:
  save_stack+0x43/0xd0 mm/kasan/kasan.c:447
  set_track mm/kasan/kasan.c:459 [inline]
  kasan_slab_free+0x71/0xc0 mm/kasan/kasan.c:524
  __cache_free mm/slab.c:3492 [inline]
  kfree+0xca/0x250 mm/slab.c:3807
  kzfree+0x28/0x30 mm/slab_common.c:1514
  crypto_destroy_tfm+0x140/0x2e0 crypto/api.c:581
  crypto_free_skcipher include/crypto/skcipher.h:212 [inline]
  crypto_put_default_null_skcipher+0x35/0x60 crypto/crypto_null.c:185
  crypto_put_default_null_skcipher2 include/crypto/null.h:22 [inline]
  aead_sock_destruct+0x13c/0x220 crypto/algif_aead.c:522
  __sk_destruct+0xfd/0x910 net/core/sock.c:1558
  sk_destruct+0x47/0x80 net/core/sock.c:1593
  __sk_free+0x57/0x230 net/core/sock.c:1601
  sk_free+0x2a/0x40 net/core/sock.c:1612
  sock_put include/net/sock.h:1657 [inline]
  af_alg_release+0x5d/0x70 crypto/af_alg.c:126
  sock_release+0x8d/0x1e0 net/socket.c:596
  sock_close+0x16/0x20 net/socket.c:1125
  __fput+0x333/0x7f0 fs/file_table.c:210
  ____fput+0x15/0x20 fs/file_table.c:244
  task_work_run+0x199/0x270 kernel/task_work.c:113
  exit_task_work include/linux/task_work.h:22 [inline]
  do_exit+0x9bb/0x1ae0 kernel/exit.c:869
  do_group_exit+0x149/0x400 kernel/exit.c:972
  SYSC_exit_group kernel/exit.c:983 [inline]
  SyS_exit_group+0x1d/0x20 kernel/exit.c:981
  entry_SYSCALL_64_fastpath+0x1f/0x96

The buggy address belongs to the object at ffff8801c7194e40
  which belongs to the cache kmalloc-128 of size 128
The buggy address is located 28 bytes inside of
  128-byte region [ffff8801c7194e40, ffff8801c7194ec0)
The buggy address belongs to the page:
page:ffffea00071c6500 count:1 mapcount:0 mapping:ffff8801c7194000 index:0x0
flags: 0x2fffc0000000100(slab)
raw: 02fffc0000000100 ffff8801c7194000 0000000000000000 0000000100000015
raw: ffffea00071b63a0 ffffea00071a8d60 ffff8801db000640 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
  ffff8801c7194d00: fb fb fb fb fb fb fb fb fc fc fc fc fc fc fc fc
  ffff8801c7194d80: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
> ffff8801c7194e00: fc fc fc fc fc fc fc fc fb fb fb fb fb fb fb fb
                                                     ^
  ffff8801c7194e80: fb fb fb fb fb fb fb fb fc fc fc fc fc fc fc fc
  ffff8801c7194f00: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
==================================================================


---
This bug is generated by a dumb bot. It may contain errors.
See https://goo.gl/tpsmEJ for details.
Direct all questions to syzkaller@...glegroups.com.
Please credit me with: Reported-by: syzbot <syzkaller@...glegroups.com>

syzbot will keep track of this bug report.
Once a fix for this bug is committed, please reply to this email with:
#syz fix: exact-commit-title
If you want to test a patch for this bug, please reply with:
#syz test: git://repo/address.git branch
and provide the patch inline or as an attachment.
To mark this as a duplicate of another syzbot report, please reply with:
#syz dup: exact-subject-of-another-report
If it's a one-off invalid bug report, please reply with:
#syz invalid
Note: if the crash happens again, it will cause creation of a new bug  
report.
Note: all commands must start from beginning of the line in the email body.

View attachment "config.txt" of type "text/plain" (126116 bytes)

Download attachment "raw.log" of type "application/octet-stream" (13521 bytes)

View attachment "repro.txt" of type "text/plain" (1246 bytes)

Download attachment "repro.c" of type "application/octet-stream" (9804 bytes)

Powered by blists - more mailing lists