linux-kernel - Re: [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 27 Nov 2017 10:57:07 -0800
From:   Joe Perches <joe@...ches.com>
To:     Logan Gunthorpe <logang@...tatee.com>,
        Julia Lawall <julia.lawall@...6.fr>
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Andy Whitcroft <apw@...onical.com>
Subject: Re: [PATCH v2] checkpatch: Add a warning for log messages that
 don't end in a new line

On Mon, 2017-11-27 at 10:44 -0700, Logan Gunthorpe wrote:
> 
> On 27/11/17 10:42 AM, Joe Perches wrote:
> > No double stardard.  One correctly informs that a bare
> > printk is not acceptable.
> 
> The other correctly informs that a printk that isn't followed by a 
> pr_cont or KERN_CONT is not correct.

It may or not be correct.

Without inter-function call code flow analysis,
it's not possible to be correct.

If you can get the false positive & false negative
rate higher, I'll listen.

I think the Coccinelle script has a better chance
to be more correct.

cheers, Joe