linux-kernel - Re: [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ec39f4f5-cfab-a184-0f27-7f0172e2984f@deltatee.com>
Date:   Sun, 26 Nov 2017 23:27:54 -0700
From:   Logan Gunthorpe <logang@...tatee.com>
To:     Julia Lawall <julia.lawall@...6.fr>
Cc:     Joe Perches <joe@...ches.com>, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org, Andy Whitcroft <apw@...onical.com>
Subject: Re: [PATCH v2] checkpatch: Add a warning for log messages that don't
 end in a new line

On 26/11/17 11:11 PM, Julia Lawall wrote:
> I don't have a different warning if the string ends in a space.  I have a
> different warning when one possible control-flow path is fine and another
> control-flow path is not.  The space thing relates to guessing whether
> some other printing API function needs a newline or not.

Understood. For checkpatch, there only is warnings (of various types)
and I was referring to the guessing you mentioned. So if we see that a
call has no new line and the following one isn't a KERN_CONT, then based
on whether there's a space or not we potentially could have one of two
warnings:

WARNING: Log messages should end in a new line (\n)

or

WARNING: Given that your log message ends in a space and not a new line,
did you maybe mean to put a KERN_CONT or pr_cont somewhere in there?? By
the way, though, KERN_CONT use is discouraged and will create its own
warning when you fix it.

Logan