linux-kernel - Re: [PATCH 1/6] staging: pi433: pi433_if.c: fix opening curly brace coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 28 Nov 2017 14:08:44 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Chase Metzger <chasemetzger15@...il.com>
Cc:     Marcus Wolf <linux@...f-Entwicklungen.de>,
        Joseph Wright <rjosephwright@...il.com>,
        Haneen Mohammed <hamohammed.sa@...il.com>,
        Cihangir Akturk <cakturk@...il.com>,
        Srishti Sharma <srishtishar@...il.com>,
        Colin Ian King <colin.king@...onical.com>,
        Al Viro <viro@...iv.linux.org.uk>,
        Derek Robson <robsonde@...il.com>, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/6] staging: pi433: pi433_if.c: fix opening curly brace
 coding style issues

On Wed, Nov 15, 2017 at 04:35:48PM -0800, Chase Metzger wrote:
> Put opening curly braces for if/else/else if statements and for/while loops
> on the same line as the statements or loops to comply with the kernel
> coding style.
> 
> Signed-off-by: Chase Metzger <chasemetzger15@...il.com>
> ---
>  drivers/staging/pi433/pi433_if.c | 110 ++++++++++++++-------------------------
>  1 file changed, 38 insertions(+), 72 deletions(-)
> 
> diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
> index ff86db1c6cbd..76d70345229a 100644
> --- a/drivers/staging/pi433/pi433_if.c
> +++ b/drivers/staging/pi433/pi433_if.c
> @@ -153,12 +153,10 @@ static irqreturn_t DIO1_irq_handler(int irq, void *dev_id)
>  {
>  	struct pi433_device *device = dev_id;
>  
> -	if      (device->irq_state[DIO1] == DIO_FifoNotEmpty_DIO1)
> -	{
> +	if      (device->irq_state[DIO1] == DIO_FifoNotEmpty_DIO1) {

Again, fix up the space issue here at the same time please.

thanks,

greg k-h