linux-kernel - Re: [PATCH v2 4/6] iommu/vt-d: Add debugfs extension to show register contents

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1511877307.25007.467.camel@linux.intel.com>
Date:   Tue, 28 Nov 2017 15:55:07 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     "Kammela, Gayatri" <gayatri.kammela@...el.com>,
        "Mehta, Sohil" <sohil.mehta@...el.com>,
        Joerg Roedel <joro@...tes.org>,
        Alex Williamson <alex.williamson@...hat.com>
Cc:     David Woodhouse <dwmw2@...radead.org>,
        "Raj, Ashok" <ashok.raj@...el.com>,
        "iommu@...ts.linux-foundation.org" <iommu@...ts.linux-foundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Jacob Pan <jacob.jun.pan@...ux.intel.com>,
        "Shankar, Ravi V" <ravi.v.shankar@...el.com>,
        "Yu, Fenghua" <fenghua.yu@...el.com>
Subject: Re: [PATCH v2 4/6] iommu/vt-d: Add debugfs extension to show
 register contents

On Mon, 2017-11-27 at 20:52 +0000, Kammela, Gayatri wrote:

> > Moreover, see the patch I have just sent [1] and use same
> > DEFINE_SHOW_ATTRIBUTE() macro here. In that case we would easily
> > move it
> > to seq_file.h for everyone to use in the future.
> 
> That makes sense! I see your patch is not merged yet, so really cannot
> reuse the same macro. I will have to redefine it.

Since response from BT maintainer he won't take seq_file.h change, just
go ahead and create a same macro (with the same name) inside your
module.

In next cycle I can easily consolidate them in one patch then against
seq_file.h.

> > [1]: https://marc.info/?l=linux-bluetooth&m=151138535801354&w=2


-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy